Nightly Windows: 3 Go workspace unit tests fail (Unix-only GOWORK paths)

Cerrado
  • ¿Algo no está bien?
#1,815 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@mikolalysenko ya está trabajando en esto.

Desde el 29/10/2026.

  • #1816 de @mikolalysenko — abierto

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
github-actions, go, rust
Área
ci-cd, devtools, testing

Línea de trabajo

Read the failing tests in go_workspace.rs at lines 1141 and 1479 and golang.rs at line 1848, then inspect the Windows nightly run linked in the issue. Run the affected tests on Windows through the CI workflow_dispatch path. Done means all three assertions pass on Windows; issue #1816 is already an open pull request against this work.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

agent:claimed agent:triaged ci-janitor priority:p3

Nightly CI on main (run 40824880386, job test (windows-latest, 1)) fails -p socket-patch-core --lib with 3 of 6536 tests failing. These are deterministic assertion failures, not flakes. They came in with #1763 / #1764 (merged 2026-10-28). PR CI and the merge queue don't run the Windows test matrix, so the queue never saw them.

vendor::go_workspace::tests::gowork_resolves_as_go_does  (go_workspace.rs:1141)
  left:  Invalid("GOWORK=/elsewhere/go.work is not an absolute path, so go refuses to build …")
  right: File("/elsewhere/go.work")

vex::discover::golang::tests::gowork_naming_another_workspace_attests_nothing  (golang.rs:1848)
  /nonexistent/go.work: [Diag { code: "patched_ref_invalid", … GOWORK=/nonexistent/go.work is not an absolute path … }]

vendor::go_workspace::tests::a_workspace_module_is_never_replaced  (go_workspace.rs:1479)
  MainModule { work_file: "\\\\?\\C:\\Users\\runneradmin\\AppData\\Local\\Temp\\.tmpSk8aez\\ws\\go.work", member: "\\\\?\\C:\\…\\ws\\dep" }

Likely fix (test side): build the GOWORK fixtures from a tempdir or another absolute path that works on each platform instead of /elsewhere and /nonexistent. For the third test, compare paths after stripping the verbatim prefix (or canonicalize both sides), or find out where \\?\ comes from (a canonicalize on Windows). Open PRs #1812 and #1800 touch both files, so the janitor didn't change them this run. Whoever lands next should check these tests on Windows (workflow_dispatch of CI).

The cargo-home half of the same nightly failure is fixed in #1814.

Lenguaje dominante
Rust
Estrellas
8
Forks
2
Merge medio
19 h 19 min
PR fusionados (30 d)
697

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de SocketDev/socket-patch

Todos los issues de SocketDev/socket-patch

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.