General testing strategy of crates in CI
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
Línea de trabajo
Start by reviewing the workspace Cargo.lock, Cargo.toml dependency patches, and existing CI jobs for stable, MSRV, and minimal-versions testing. The issue proposes three dependency resolution scenarios but leaves key choices unresolved, including lockfile policy and how to handle patches. A concrete outcome would be an agreed testing strategy and CI changes covering the chosen scenarios.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Most of our repositories contain multiple crates which are part of the same workspace. We also have a number of inter-repository dependencies (e.g. digest depends on crypto-common). In such cases instead of using path while specifying dependency in the crate's Cargo.toml we use dependency patching (e.g. see here).
Currently we commit workspace's Cargo.lock and update it periodically using Dependabot. It allows us to isolate CI failures caused by upstream dependencies. It also reduces CI times a bit since we don't need to generate lock files from scratch. We use the same Cargo.lock for both MSRV and stable tests. MSRV tests use versions manually provided in the CI config.
Additionally, we have minimal-versions jobs which test crates separately from the repository workspace using unstable -Z minimal-versions option. Unfortunately, testing it outside of workspace means that dependency patching defined on the workspace level does not works and we have to manually disable such jobs while patching is present.
In the new releases we plan to rely on the MSRV-aware resolver meaning that we can update MSRV in patch releases, which can lead to mixed-MSRV workspaces. Considering how the MSRV-aware resolver works by default (it selects dependency versions compatible with the declared MSRV), it may be problematic.
Imagine a repo with crates A and B with MSRV equal to 1.85, now in a new version of A we want to use dependency C with MSRV 1.90. We bump MSRV of crate A accordingly, but now we have a problem: the resolver is unable to generate Cargo.lock compatible with MSRV of crate B.
Going forward, I think we should test at least 3 scenarios for all crates:
- Stable toolchain with latest semver-compatible dependencies (i.e. generated with
cargo update --ignore-rust-version) - MSRV toolchain acquired from the
rust-versionfield with latest MSRV-compatible dependencies - Nightly toolchain with minimal semver-compatible version (i.e. generated with
-Z minimal-versions)
This list would require the following changes:
- If we want to continue committing Cargo.lock we should add
.cargo/config.tomlto every repository withincompatible-rust-versions = "allow"to satisfy 1. - To satisfy 2 we would need to add extraction of the
rust-versionvalue (see this URLO thread) and to exclude the crate from the repo workspace.
Unresolved questions:
- Should we continue to commit Cargo.lock? I don't remember many cases of upstream dependencies breaking CI, so it may not be important. We could replace it with a cron job which would test freshest upstream dependencies periodically.
- Should we test on Nightly and/or Beta with latest semver-compatible dependencies?
- Should we use MSRV toolchain to run tests
minimal-versionsjobs (i.e. use Nightly to generate lock file and switch to MSRV toolchain forcargo test)? - How to deal with
patchissues in 2 and 3?
- Lenguaje dominante
- Sin datos de lenguaje
- Estrellas
- 13
- Forks
- 4
- Merge medio
- 41 min
- PR fusionados (30 d)
- 1
Preparar el entorno
Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de RustCrypto/meta
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
RustCrypto/meta#38 · 5 comentarios ·
-
Proof systemAbierto
Dificultad 5/5 Más de una semana Aptitud para principiantes 20/100
RustCrypto/meta#37 · 3 comentarios ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
RustCrypto/meta#36 · 8 comentarios ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 32/100
RustCrypto/meta#34 · 8 comentarios ·
-
Replace `subtle` with `ctutils`?Quizá libre de nuevo @newpavlov la tomó hace 323 días y no hay ningún pull request abierto. Abierto
RustCrypto/meta#29 · 1 comentario · 1 asignado ·
Todos los issues de RustCrypto/meta
Issues similares
-
Release: a tag the manifests do not match fails `check`, and every build job still runs to the endAbiertoCI/CD enhancement need-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 67/100
Los mantenedores suelen responder en 1 día
-
backend bug frontend
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 5 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
NVIDIA/numba-cuda-mlir#467 · 1 comentario ·
Los mantenedores suelen responder en 3 días