SlackBridge: Slack links <url|label> arrive as broken text "url|label" (no link, no preview)
Los mantenedores suelen responder en 1 día
Evaluación
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Estancado
- Stack tecnológico
- typescript
- Área
- backend
Línea de trabajo
Read apps/meteor/server/bridges/slack/RocketAdapter.ts, especially convertSlackMsgTxtToRocketTxtFormat around line 529, and compare its link handling with apps/meteor/server/lib/import/slack/SlackImporter.ts around lines 692–693. Check the existing bridge tests for this conversion, then verify that labeled Slack links render with the intended target and URL previews. An open linked pull request (#43590) already addresses this issue.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Description:
SlackBridge does not convert Slack's link markup <url|label>. It only strips the angle brackets, so every link with a label arrives in Rocket.Chat as the literal text url|label. The message parser then treats the whole url|label string as one URL, so the link points to a wrong address and no URL preview is fetched.
Slack sends almost every link this way. Pasted links are usually <https://x.com/user/status/123|x.com/user/status/123>, and links with custom text are <https://example.com|some text>. On our workspace, where most messages come through SlackBridge, this affected about 15,000 bridged messages.
Steps to reproduce:
- Set up SlackBridge between a Slack workspace and Rocket.Chat.
- In a bridged Slack channel, post a link, e.g.
https://x.com/user/status/123, or a link with custom text. - Look at the bridged message in Rocket.Chat.
Expected behavior:
<https://x.com/user/status/123|x.com/user/status/123>becomeshttps://x.com/user/status/123: a clickable link that gets a preview.<https://example.com|some text>becomes[some text](https://example.com).
Actual behavior:
The message text is https://x.com/user/status/123|x.com/user/status/123. The rendered link target is that whole string, and the message's urls contains it too, so the OEmbed lookup fails and no preview is shown.
Cause:
convertSlackMsgTxtToRocketTxtFormat in apps/meteor/server/bridges/slack/RocketAdapter.ts handles links with a single replace that keeps the |label part:
slackMsgTxt = slackMsgTxt.replace(/<(http[s]?:[^>]*)>/g, '$1');
The Slack importer already handles the same markup correctly:
message = message.replace(/<(http[s]?:[^>|]*)>/g, '$1');
message = message.replace(/<(http[s]?:[^|]*)\|([^>]*)>/g, '[$2]($1)');
Using the importer's two replacements in the bridge would fix the broken links. Two details from patching this locally:
- When the label is just the URL itself (Slack's usual case: the URL without scheme, or a shortened form with
…), emitting the bare URL is better than[label](url). The parser autolinks a URL-looking label inside the markdown link, and the bare form keeps previews working. - The link replacement runs after
>is decoded (line 522), so a label containing>gets cut at that character. Converting links before the HTML entity decode avoids this.
Server Setup Information:
- Version of Rocket.Chat Server: 8.9.1 (the same code is on
developat 7625d7c and in 9.0.0-rc.8) - License Type: Community
- Number of Users: 38
- Operating System: Linux (Ubuntu, kernel 6.8)
- Deployment Method: docker
- Number of Running Instances: 1
- DB Replicaset Oplog: enabled (single-node replica set)
- NodeJS Version: 24.22.1
- MongoDB Version: 8.2.3
Client Setup Information
- Desktop App or Browser Version: any (the stored message text is wrong, so it does not depend on the client)
- Operating System: any
Additional context
We are running a locally patched image with this fix for now. I can open a PR if that would help.
Relevant logs:
No errors are logged; the conversion succeeds but produces the wrong text.
- Lenguaje dominante
- TypeScript
- Estrellas
- 46.5k
- Forks
- 14.1k
- Merge medio
- 1 d 21 h
- PR fusionados (30 d)
- 381
Preparar el entorno
Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de RocketChat/Rocket.Chat
-
Mark the empty state busy while a new search loads, like the table */}Posiblemente ocupada @aditya25bcy10173-a11y la tomó hace 2 días. Abiertotodo type: feature
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
RocketChat/Rocket.Chat#43699 · 1 comentario · 1 reacción ·
Los mantenedores suelen responder en 1 día
-
Timestamp with a time but no timezone shows as 1 January 1970Posiblemente ocupada @Sarthak-agrawal-tech la tomó hace 4 días. Abiertotype: bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
RocketChat/Rocket.Chat#43637 · 6 comentarios ·
Los mantenedores suelen responder en 1 día
-
Move this mapping from useQuery's old `select` into a usePaginatedQuery `combine`Posiblemente ocupada @aditya25bcy10173-a11y la tomó hace 3 días. Abiertotodo type: feature
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
RocketChat/Rocket.Chat#43609 · 4 comentarios · 1 reacción ·
Los mantenedores suelen responder en 1 día
-
evaluate switching to the other tab when the selected tab's permission is revoked mid-sessionPosiblemente ocupada @schizophrenicmaniac la tomó hace 4 días. Abiertotodo type: feature
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
RocketChat/Rocket.Chat#43579 · 3 comentarios · 1 reacción ·
Los mantenedores suelen responder en 1 día
-
Docs say packages can be installed with `npm` but use unsupported `patch:` URLPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abiertotype: bug
Dificultad 1/5 1-3 horas Aptitud para principiantes 72/100
RocketChat/Rocket.Chat#43554 · 4 comentarios ·
Los mantenedores suelen responder en 1 día
Todos los issues de RocketChat/Rocket.Chat
Issues similares
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
langchain-ai/langchainjs#12239 ·
Los mantenedores suelen responder en 1 día
-
Board view: the Monitoring column is always empty because compact issue rows drop displayStatusAbierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
paperclipai/paperclip#21837 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 73/100
code-yeongyu/senpi#6813 ·
Los mantenedores suelen responder en 1 día
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Dificultad 1/5 Menos de una hora Aptitud para principiantes 93/100
lingdojo/kana-dojo#34169 · 1 comentario · 5 reacciones ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100