Feature request: Include restore error details in VirtualMachineFileRestore phase-wait failures

Abierto
  • ¿Algo no está bien?
#2,847 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
67/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
backend

Línea de trabajo

Read ocp_resources/virtual_machine_file_restore.py and inspect the existing wait behavior in ocp_resources/resource.py to choose the helper interface. Add focused tests for reaching the requested phase, failure with status.errorMessage, and failure without it. Done means the helper reports useful failure details while inherited wait_for_status() behavior remains unchanged for other callers and phases.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

Add a restore-specific phase-wait helper to VirtualMachineFileRestore in a follow-up PR.

When a restore reaches Failed while a caller waits for a successful phase, include the operator-provided status.errorMessage in the failure details. This will make restore failures easier to diagnose without a separate status lookup.

Required changes

  • Add the helper in ocp_resources/virtual_machine_file_restore.py, outside the generated-code markers.
  • Detect the Failed phase while waiting for the requested successful phase and report status.errorMessage when available.
  • Handle an absent or empty error message without introducing a secondary exception.
  • Preserve the inherited wait_for_status() behavior for other callers and phases.
  • Document the helper and add focused tests.

The implementation can inspect ocp_resources/resource.py for the existing wait behavior before selecting the helper's interface.

Acceptance criteria

  • A successful restore returns as documented when it reaches the requested phase.
  • A failed restore reports the failed phase and the operator error message when available.
  • Missing error details still produce a useful failure diagnostic.
  • Existing wait behavior remains unchanged outside the new helper.
  • Tests cover success, failure with an error message, and failure without an error message.

Context

Requested by @ema-aka-young for a separate PR, rather than expanding PR #2846.

Lenguaje dominante
Python
Estrellas
28
Forks
85
Merge medio
1 d 3 min
PR fusionados (30 d)
30

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de RedHatQE/openshift-python-wrapper

Todos los issues de RedHatQE/openshift-python-wrapper

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.