SImplifying read_cst_beam

Abierto
#1,236 0 comentarios 1 reacción 2 asignados Ver en GitHub

Los mantenedores suelen responder en 3 días

@bhazelton ya está trabajando en esto.

Desde el 8/12/2022.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

beams technical debt

Having a look through UVData.read_cst_beam I get the impression it could be MUCH simplified. Some things I noticed:

  1. There is a discrepancy between some of the keywords to the function, and the keys expected in the YAML file (eg. "frequency/frequencies" and "reference_impedance/ref_imp").
  2. Exactly the same huge set of parameters is used, copy-pasted 3 times in the function. At the very least, these should be packed up into a dict and unpacked on each call.
  3. There's a bunch of weird handling of over-riding YAML inputs with direct inputs to the function. I think it's debatable whether this should be allowed at all (isn't that allowing bad practice?), but if we do allow it, it would be much much easier to take in the parameters of the function as an explicit dictionary, and just do a dict update (point 1 would have to be fixed, of course). This would remove at least 3 repetitions of naming every single parameter that I can see.
Lenguaje dominante
Python
Estrellas
103
Forks
40
Merge medio
4 d 11 h
PR fusionados (30 d)
13

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de RadioAstronomySoftwareGroup/pyuvdata

Todos los issues de RadioAstronomySoftwareGroup/pyuvdata

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.