Opening Find in an unrelated webview activates vscode-R and shows `R: (not attached)` in non-R workspaces
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 55/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Tranquilo
- Stack tecnológico
- typescript, vscode
- Área
- developer-experience, tooling
Línea de trabajo
Comienza con package.json y las contribuciones del menú editor/title para editor.action.webvieweditor.showFind; después, reproduce la activación desde una vista previa de Markdown usando el atajo de Find indicado. Comprueba exthost.log para ver el evento de activación; estará hecho cuando un webview no relacionado ya no active vscode-R ni muestre R: (not attached), mientras los webviews de R conservan su acción Find.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Describe the bug
The R extension activates and shows its session status bar item R: (not attached)
even in a workspace with no R files, simply because I triggered the Find widget
in an unrelated webview, such as a Markdown preview.
On my Windows machine, R itself is not installed at all — I only installed the
vscode-R extension. That alone is enough for R: (not attached) to show up once Find
is opened in an unrelated webview, so this is purely about extension activation, not
about any R file, R session, or R runtime.
The likely trigger is that package.json contributes the built-in command
editor.action.webvieweditor.showFind (titled "R: Find in WebView"). This command is
then used in editor/title menus gated by r.browser.active / r.helpPanel.active.
Since VS Code 1.74.0, a command contributed in package.json implicitly activates the
extension when that command is invoked. Because editor.action.webvieweditor.showFind
is the shared built-in webview Find command, invoking Find in any webview
(Markdown preview, release notes, etc.) activates vscode-R, not just R's own
help/browser panels.
Confirmed in exthost.log:
ExtensionService#_doActivateExtension REditorSupport.r, startup: false,
activationEvent: 'onCommand:editor.action.webvieweditor.showFind'
To Reproduce
- Open a folder that contains no R-related files (
.R,.Rmd,.Rproj, etc.). - Open a webview-based editor with a Find widget, e.g. a Markdown preview.
- Focus that preview and press
Cmd+Fon macOS /Ctrl+Fon Windows or Linux.
In my environment, this invokes the built-ineditor.action.webvieweditor.showFind. - The vscode-R extension activates and
R: (not attached)appears in the status
bar, despite no R file or R session being present. It stays visible until the
window is reloaded.
I have reproduced this on both macOS (Cmd+F) and Windows (Ctrl+F), so it does
not appear to be platform-specific.
Can you fix this issue by yourself? (We appreciate the help)
No, but I am happy to test a fix or provide more logs.
(If yes,) can we assist you with anything?
N/A
(If applicable) Please attach setting.json
On macOS, the only R setting I customized is:
"r.rpath.mac": "/usr/local/bin/R"
r.sessionWatcher is left at its default value, true.
On Windows, my settings.json has no r.* keys at all, and R is not installed.
Only the vscode-R extension is present. The bug still reproduces.
Expected behavior
The extension should not activate, and the session status bar item should not appear,
merely because Find was opened in an unrelated webview.
The "R: Find in WebView" action should be scoped to R's own webviews only, without
contributing the shared built-in webview Find command id in a way that causes global
activation from unrelated webviews.
Possible approaches:
- avoid contributing the built-in command id
editor.action.webvieweditor.showFind
directly incontributes.commands; - use a vscode-R wrapper command that is only exposed for R webviews and internally
calls the built-in Find command; - or hide the session status bar item unless an R-related editor, workspace, session,
or webview is actually relevant.
This seems related in spirit to #1572 / #1579, where R UI was made conditional so it
does not appear in unrelated workspaces.
Screenshots
The status bar shows R: (not attached) in a workspace with no R files. I can attach
a screenshot if useful.
Environment (please complete the following information):
- OS: reproduced on both macOS and Windows
- VS Code Version: 1.122.1
- R Version: N/A — reproduces with no R session involved. On Windows, R is not even
installed; only the vscode-R extension is present. - vscode-R version: 2.8.8
Additional context
When r.sessionWatcher is enabled, which is the default, activation creates and shows
the session status bar item. Therefore, once vscode-R is activated by the unrelated
webview Find command, R: (not attached) remains visible for the rest of the window
session, even though the current workspace/editor is unrelated to R.
- Lenguaje dominante
- TypeScript
- Estrellas
- 1.2k
- Forks
- 139
- Merge medio
- 23 h 31 min
- PR fusionados (30 d)
- 13
Preparar el entorno
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de REditorSupport/vscode-R
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
REditorSupport/vscode-R#1687 · 4 comentarios · 3 reacciones ·
Los mantenedores suelen responder en 1 día
-
feature-request
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
REditorSupport/vscode-R#1763 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
REditorSupport/vscode-R#1755 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
REditorSupport/vscode-R#1751 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
REditorSupport/vscode-R#1749 · 5 comentarios · 3 reacciones ·
Los mantenedores suelen responder en 1 día
Todos los issues de REditorSupport/vscode-R
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
diegosouzapw/OmniRoute#14869 ·
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 94/100
Los mantenedores suelen responder en 1 día
-
status: waiting triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
freeCodeCamp/freeCodeCamp#70412 ·
Los mantenedores suelen responder en 1 día
-
Mend: dependency security vulnerability untriaged
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
opensearch-project/OpenSearch-Dashboards#12816 ·
Los mantenedores suelen responder en 1 día