Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

TradeStationBrokerageModel rejects extended-hours limit orders on equity options

Abierto Apto para principiantes
  • ¿Algo no está bien?
#9,920 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@AlexCatarino ya está trabajando en esto.

Desde el 20/10/2026.

  • #9928 de @AlexCatarino — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
78/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
csharp
Área
api, backend

Línea de trabajo

Empieza por Common/Brokerages/TradeStationBrokerageModel.cs, en torno a la comprobación CanSubmitOrder descrita en el issue. Lee las propiedades de las órdenes de TradeStation y la correspondencia de la vigencia de la orden para confirmar qué tipos de órdenes y de valores se aceptan. Actualiza la comprobación de elegibilidad y el texto de advertencia según lo propuesto, manteniendo rechazadas las opciones sobre índices; el trabajo estará terminado cuando las órdenes limitadas de acciones y opciones sobre acciones con la marca pasen, mientras que los tipos no compatibles sigan rechazándose.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Expected Behavior

With the TradeStation brokerage model, a limit order on an equity option carrying TradeStationOrderProperties.OutsideRegularTradingHours = true should pass CanSubmitOrder and reach the brokerage with the extended-hours duration (DYP / GCP / GDP).

TradeStation opened extended-hours options trading on 2026-10-19 (Cboe sessions 07:30-09:25 ET and 16:00-16:15 ET, limit orders only, Day+ / GTC+ / GTD+ durations, options on a set of single stocks and ETFs): https://www.tradestation.com/insights/extended-hours-options-trading/

Actual Behavior

TradeStationBrokerageModel.CanSubmitOrder rejects every order with the flag set unless it is a limit order on an equity, so an extended-hours option limit order is marked Invalid before it reaches the brokerage, in backtesting and in live trading alike:

BrokerageModel declared unable to submit order: [1] Warning - Code: NotSupportedOutsideRegularMarketHours - To place an order outside regular trading hours, please use a limit order and ensure the security is an equity.

Common/Brokerages/TradeStationBrokerageModel.cs (master, lines 132-138):

var supportsOutsideTradingHours = (order.Properties as TradeStationOrderProperties)?.OutsideRegularTradingHours ?? false;
if (supportsOutsideTradingHours && (order.Type != OrderType.Limit || order.SecurityType != SecurityType.Equity))
{
    message = new BrokerageMessageEvent(BrokerageMessageType.Warning, "NotSupportedOutsideRegularMarketHours",
        "To place an order outside regular trading hours, please use a limit order and ensure the security is an equity.");
    return false;
}

The brokerage plugin itself does not restrict by asset class: TradeStationExtensions.GetBrokerageTimeInForce maps Day / GTC / GTD to DayPlus / GoodTillCanceledPlus / GoodThroughDatePlus whenever the flag is set, for any security type, and TradeStationApiClient.CreatePlaceOrderRequest passes that duration through. Only the engine-side model stands in the way.

Reproduce

QC Cloud, LEAN 2.5.0.0.18194, project 38117137, backtest 1be63f12c2f791724afe25fd9ea34d4a. One option limit order and one equity limit order, both with the flag set, under the TradeStation model:

from AlgorithmImports import *


class TradeStationExtendedHoursOptionOrderRepro(QCAlgorithm):

    def initialize(self) -> None:
        self.set_start_date(2024, 1, 2)
        self.set_end_date(2024, 1, 3)
        self.set_cash(100000)
        self.set_brokerage_model(BrokerageName.TRADE_STATION, AccountType.MARGIN)
        self._equity = self.add_equity("SPY", Resolution.MINUTE).symbol
        option = self.add_option("SPY", Resolution.MINUTE)
        option.set_filter(-2, 2, 0, 30)
        self._option = option.symbol
        self._done = False

    def on_data(self, slice: Slice) -> None:
        if self._done:
            return
        chain = slice.option_chains.get(self._option)
        if not chain:
            return
        contract = sorted(chain, key=lambda c: abs(c.strike - chain.underlying.price))[0]

        props = TradeStationOrderProperties()
        props.outside_regular_trading_hours = True
        props.time_in_force = TimeInForce.DAY

        limit = contract.bid_price if contract.bid_price > 0 else 0.5
        option_ticket = self.limit_order(contract.symbol, 1, limit, order_properties=props)
        self.log(f"OPTION limit order {option_ticket.order_id} on {contract.symbol.value}: status={option_ticket.status}")

        equity_price = self.securities[self._equity].price
        equity_ticket = self.limit_order(self._equity, 1, round(equity_price * 0.99, 2), order_properties=props)
        self.log(f"EQUITY limit order {equity_ticket.order_id} on SPY: status={equity_ticket.status}")
        self._done = True

    def on_order_event(self, order_event: OrderEvent) -> None:
        self.log(f"ORDER EVENT: {order_event}")

Output:

2024-01-02 09:31:00 BrokerageModel declared unable to submit order: [1] Warning - Code: NotSupportedOutsideRegularMarketHours - To place an order outside regular trading hours, please use a limit order and ensure the security is an equity.
2024-01-02 09:31:00 OPTION limit order 1 on SPY   240102C00474000: status=INVALID
2024-01-02 09:31:00 EQUITY limit order 2 on SPY: status=SUBMITTED

Proposed change

Accept SecurityType.Option alongside SecurityType.Equity in that check (the order type must stay Limit, which matches TradeStation's rule), and update the message accordingly. TradeStation then applies its own eligibility rules (which option classes, which session) and rejects what it does not accept, as it does for equities today.

Open question: whether SecurityType.IndexOption should be included. TradeStation's announcement covers options on select stocks and ETFs; Cboe's index options (SPX, VIX) trade in their own global trading hours session, and we have not confirmed whether TradeStation routes DYP / GCP / GDP index option orders. The fix here leaves index options rejected.

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue

Intercom conversation 215476463234198.

Lenguaje dominante
C#
Estrellas
22.1k
Forks
5.3k
Merge medio
1 d 6 h
PR fusionados (30 d)
44

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de QuantConnect/Lean

Todos los issues de QuantConnect/Lean

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.