Close stray process when stdio pipe is closed or possibly when parent process is killed (daemon flag?)
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 30/100
Línea de trabajo
Revisa primero issue #655 y PR #663; después, sigue los puntos de entrada de PSES para el modo -stdio y el indicador -daemon propuesto. Decide qué comportamiento de apagado se pretende cuando el proceso padre desaparece o la tubería stdio se cierra; se considerará terminado cuando ya no queden procesos PSES huérfanos en el escenario cubierto sin romper el uso como daemon.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
This is continuation of the effort from:
- Issue https://github.com/PowerShell/PowerShellEditorServices/issues/655 PSES needs to shutdown itself when it's supposed to
- PR https://github.com/PowerShell/PowerShellEditorServices/pull/663 Close stray processes on exit
#655 was closed by @TylerLeonhardt as it was satisfied by PR #663. However I still believe we can easily get into the situation when LSP text editor that launches PSES gets killed and orphans the PSES process, that keeps running without a purpose. Actually this is the case with Sublime Text and LSP plugin, where other language LSP providers shutdown themselves when the Sublime Text quits without a need to use exit or any other means.
Therefore I propose 2 options for consideration (alternatives):
-
Introduce new
-daemonflag, that unless specified, makes PSES to shutdown itself when the parent process disappears. This will make PSES behave like most of the command line tools, i.e. shutdown itself when the shell or launching process quits.The only purpose for PSES to run despite of parent process being alive or not is when it is it intended to be ran as a daemon, and I believe this intent should not be default (as it is now).
-
Shutdown itself when running as
-stdioand when pipe is closed, as I was commenting in other ticket, there is no point running when pipe is closes, because there is nobody that will be able to issueexitand any other command anyways.
Thank you in advance for considering my suggestion. If you prefer I can try to get this behavior adapter myself and send the PR, but you (maintainers) may come to more elegant solution much quicker than me, therefore I post this issue first.
- Lenguaje dominante
- C#
- Estrellas
- 767
- Forks
- 266
- Merge medio
- 3 d 16 h
- PR fusionados (30 d)
- 1
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de PowerShell/PowerShellEditorServices
-
[Bug] None of the string overloads of `EditorExtensionServiceProvider.GetService()` work on .NET. Abierto
PowerShell/PowerShellEditorServices#2331 · 1 reacción · 2 asignados ·
-
Area-Language Server Issue-Enhancement
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
PowerShell/PowerShellEditorServices#2315 · 1 comentario ·
-
Area-Debugging Issue-Enhancement
PowerShell/PowerShellEditorServices#2294 · 1 reacción · 2 asignados ·
-
Issue-Bug Needs: Triage
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
PowerShell/PowerShellEditorServices#2293 · 1 comentario ·
-
PowerShell/PowerShellEditorServices#2282 · 1 comentario · 1 reacción · 2 asignados ·
Todos los issues de PowerShell/PowerShellEditorServices
Issues similares
-
Documentation
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
cake-build/cake#5024 ·
-
Gå gjennom ESLint-suppressions AbiertoFrontend status/draft TechnicalDebt
Dificultad 2/5 1-2 días Aptitud para principiantes 75/100
Altinn/altinn-auth#4143 ·
-
.NET Flaky Test Testing Tests
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
getsentry/sentry-dotnet#5617 · 1 comentario ·
-
Add more to the documentation Abierto:watch: Not Triaged dotnet-fsharp/svc
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
-
Client customer-reported needs-team-attention question Service Attention WebPubSub
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
Azure/azure-sdk-for-net#63292 · 3 comentarios · 1 reacción ·