Enforce sim.microdata.weight-stripping-confined and delete its empty baseline

Cerrado
  • ¿Algo no está bien?
#1,008 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Ya se ha fusionado un pull request relacionado.

  • #1009 de @anth-volk — fusionado

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
backend, documentation, testing

Línea de trabajo

Start with projects/policyengine-simulation-executor/tests/test_microdata_weight_boundaries.py, simulation_output_common.py, and docs/engineering/skills/microdata-weights.md; check how the Test job enforces the rule and how the current guard reads recorded exceptions. Enforce sim.microdata.weight-stripping-confined, allowing raw weighted values only for counting in _count_output_entities, and remove the empty baseline. Done when other reads fail, the guard no longer reads exceptions, and the docs describe the enforced rule.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Phase 1 step 1.9 of the rules work. sim.microdata.weight-stripping-confined is ratcheted, but its baseline, rules/baselines/sim-microdata-weight-stripping.txt, has had no entries since the last recorded exception, _unweighted_household_frame, was removed. The baseline holds only comments and its count is 0.

The rule becomes enforced: raw values are read from a weighted frame or column only to count entities, in _count_output_entities in simulation_output_common.py, and any other read fails the executor's Test job. The baseline file is deleted, the guard in projects/policyengine-simulation-executor/tests/test_microdata_weight_boundaries.py stops reading recorded exceptions, and docs/engineering/skills/microdata-weights.md describes the enforced rule.

Lenguaje dominante
Python
Estrellas
1
Forks
1
Merge medio
2 d 48 min
PR fusionados (30 d)
87

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de PolicyEngine/policyengine-sim-api

Todos los issues de PolicyEngine/policyengine-sim-api

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.