Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Telemetry error report splits a simulation worker failure between its exception and the recorded copy

Cerrado
  • ¿Algo no está bien?
#4,088 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Ya se ha fusionado un pull request relacionado.

  • #4089 de @anth-volk — fusionado

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
20/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
python
Área
observability

Línea de trabajo

Read .github/scripts/telemetry_error_issues/records.py, especially primary_records and _primary_preference, then inspect failure_causes.record_failure_cause and its record_exception(handled=True) call. Check how Stage12FailureCause is identified and how fingerprint algorithm 2 relates to issue #4085. Done means the original exception represents a failure when both records exist, while the copy still represents failures when it is the only record.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

What happens

When a simulation worker or coordinator fails on the simulation service's newer report path, the service logs two ERROR records for the one failure:

  • the original exception, for example ValueError: No dataset found for year 2033: a log record with error.type set, no event.name and no error.handled;
  • a redacted copy written by failure_causes.record_failure_cause through record_exception(handled=True): an exception.recorded event with error.type Stage12FailureCause and error.handled true, carrying the original's traceback. A worker's copy often has the original's frames and timestamp to the microsecond.

primary_records in .github/scripts/telemetry_error_issues/records.py keeps one record per failure, and _primary_preference ranks both as exceptions. When the timestamps tie, the record whose fingerprint inputs sort first wins, which is the copy for a ValueError. So one cause splits across two error groups and two issues. On 2026-10-26, policyengine-stage12-uk-worker groups a8e6ee4984a289c0 and 88e59fcf916bc9ff were one cause.

Proposed change

Rank a Stage12FailureCause record after other exceptions and before messages and failed requests, so the original exception represents the failure. A failure with only the copy still uses the copy.

The copy sets no event name or attribute of its own (exception.recorded and error.handled are what the runtime writes for any handled exception), so its class is the only field that tells it apart.

This changes which record represents those failures, so it should ship with fingerprint algorithm 2 (#4085) rather than need another algorithm change.

Lenguaje dominante
Python
Estrellas
18
Forks
33
Merge medio
2 d 7 h
PR fusionados (30 d)
64

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de PolicyEngine/policyengine-api

Todos los issues de PolicyEngine/policyengine-api

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.