[io] pcl::io::raw_open opens files in text mode on Windows, so raw_read alters binary data

Abierto Apto para principiantes
#6,536 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 3 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
1/5
Tiempo estimado
Menos de una hora
Aptitud para principiantes
82/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
cpp

Línea de trabajo

Empieza en pcl/io/low_level_io.h, en la rama _WIN32 donde raw_open envuelve ::_open; compara esas sobrecargas con las de POSIX. Reproduce con un archivo binario diminuto que contenga 0D 0A y 1A, como en el issue, y comprueba los recuentos de bytes de raw_read. Luego ejercita los llamadores afectados PCDReader::read para archivos binary_compressed y LineRGBD::loadTemplates. Hecho significa que raw_read de Windows devuelve los bytes del archivo sin cambios y ya no trunca en CRLF ni en 0x1A.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

kind: bug status: triage

Describe the bug

On Windows, pcl::io::raw_open (pcl/io/low_level_io.h) calls ::_open without _O_BINARY. The CRT default translation mode is text (_O_TEXT, unless the application changes _fmode). As a result, pcl::io::raw_read on that descriptor:

  • collapses every CR LF pair into LF, compacting the buffer in place, and returns fewer bytes;
  • stops at a 0x1A byte.

POSIX open has no text mode, so the same code reads different bytes on Linux and Windows.

PCL reads binary data through these wrappers: PCDReader::read for binary_compressed files and LineRGBD::loadTemplates. raw_open/raw_read are also public API for user code.

Expected behavior

raw_read returns the file's bytes unchanged, as it does on POSIX.

Current Behavior

A file holds the bytes 0D 0A 00 01 40 00 00 02, and 4 bytes are read from it:

| open flags | _read returns | buffer
| O_RDONLY (what raw_open does) | 3 | 0A 00 01 01
| O_RDONLY \| _O_BINARY | 4 | 0D 0A 00 01

With the bytes 1A 0A 00 00, text mode returns 0.

Consequences:

  • LineRGBD::loadTemplates reads each .sqmmt entry with raw_read (ltm_fd, buffer, fsize) and checks only for -1. After the first 0D 0A pair, every following byte is shifted by one and the tail holds stale bytes. sqmmt.deserialize then reads corrupted data.
  • PCDReader::read reads the 4-byte compressed size of a binary_compressed file with raw_read and checks only num_read < 0. On Windows the value is used only for the file-size check, because the whole file is mapped. When translation makes the value larger, a valid file is rejected with "Corrupted PCD file. The file is smaller than expected!". For example, a compressed size of 0x01000A0D (16 779 789 bytes) is read as 0x0101000A, which is 62 973 bytes too large.

To Reproduce

#include <pcl/io/low_level_io.h>
#include <fcntl.h>
#include <cstdio>
#include <fstream>

int main ()
{
  const unsigned char bytes[] = {0x0D, 0x0A, 0x00, 0x01};
  std::ofstream ("crlf.bin", std::ios::binary).write (reinterpret_cast<const char*> (bytes), sizeof (bytes));

  int fd = pcl::io::raw_open ("crlf.bin", O_RDONLY);
  unsigned char buf[4] = {};
  const auto n = pcl::io::raw_read (fd, buf,
  pcl::io::raw_close (fd);
  std::printf ("n=%d %02X %02X %02X %02X\n",, buf[1], buf[2], buf[3]);
  // Linux:   n=4 0D 0A 00 01
  // Windows: n=3 0A 00 01 01
}

Your Environment (please complete the following information):

  • OS: Windows 11
  • Compiler: MSVC (Visual Studio 2026)
  • PCL Version: 1.12.1 and current master

Possible Solution

Open in binary mode inside the Windows wrappers. O_BINARY does not exist on POSIX, so callers cannot pass it portably.

#ifdef _WIN32
# include <fcntl.h> // _O_BINARY
...
    inline int raw_open(const char * pathname, int flags, int mode)
    {
      return ::_open(pathname, flags | _O_BINARY, mode);
    }

    inline int raw_open(const char * pathname, int flags)
    {
      return ::_open(pathname, flags | _O_BINARY);
    }
Lenguaje dominante
C++
Estrellas
11.2k
Forks
4.7k
Merge medio
6 d 13 h
PR fusionados (30 d)
10

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de PointCloudLibrary/pcl

Todos los issues de PointCloudLibrary/pcl

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.