API inconsistency with DPI_AWARE flag
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
Línea de trabajo
Comienza rastreando r_renderer_c::VirtualScreenScaleFactor() y los puntos de entrada de la API GetScreenSize y GetScaleFactor; después, compara cómo las funciones de renderizado manejan sus argumentos de posición y tamaño. Revisa los cambios de DPI_AWARE en los PRs 44, 80 y 86, así como el código de escalado relacionado de Win32/GLFW. Se considera terminado cuando el contrato de la API y el comportamiento del escalado en tiempo de ejecución son coherentes, y el comportamiento previsto de Lua está cubierto por pruebas o por un procedimiento de verificación documentado.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
The DPI_AWARE flag was introduced with https://github.com/PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic/pull/44/commits/59492a4003ea77c03f9ae62c5e66a13afd02f313 as a way for the Lua code to opt out of the virtualization and get access to physical sizes/positions.
With the recent work on UI scaling in https://github.com/PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic/pull/80 and https://github.com/PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic/pull/86, the API has ended up in an inconsistent state where some functions use physical units if DPI_AWARE is set, but others still use virtual units in its arguments and return values.
For example, GetScreenSize returns physical units (i.e. the pixel size of the framebuffer), while all the other API functions still receive and return virtual units. It looks like PoB Lua code is not ready to deal with physical units, so the screen size is actually mapped right back to virtual units. Maybe PoB just shouldn't set the DPI_AWARE flag yet because everything seems to be done in virtual units at the moment. But that leads us to the second problem(?):
With the current implementation of r_renderer_c::VirtualScreenScaleFactor() and its usage in the API functions, the DPI_AWARE flag seems to serve two different functions:
- A way to influence the "API contract" between the Lua code and SimpleGraphic. Setting it tells the API to accept and return positions and sizes in physical units instead of virtual units (this seems to be in line with the original intention of this flag).
- To control whether application UI scaling is performed by the runtime. Before the recent changes,
VirtualScreenScaleFactorwas only used to determine which factor to return to Lua in theGetScaleFactorAPI function. Currently, it is also being used in the render functions to scale their position/size arguments. Not setting the flag means1.0is always returned, effectively turning off scaling.
The second behavior surprised me a bit. This means we cannot unset the flag and only use virtual units between Lua <-> Runtime because it would turn off the scaling entirely.
Here is how i expected it to work:
- Make the runtime always DPI aware and perform app scaling: I'm not very familiar with the win32 api but it looks like we can tell the OS that our application is per-monitor (v2) DPI aware. Maybe that's already the case? I've also spotted code that checks registry values to decide whether to ignore the scaling factor returned by GLFW. Not sure if that's needed anymore.
- Have the flag only affect the API contract, meaning physical units are used between Lua and SimpleGraphic if the flag is set, otherwise we only let Lua know about the virtual world. Not setting the flag shouldn't have any effect on whether scaling is performed.
- If users want to override the scaling factor given by the OS, they can use the newly added scaling factor override in the settings.
- With these changes, we can unset the
DPI_AWAREflag again, since PoB doesn't currently care about the physical world, but still retain the scaling behavior.
If i'm missing something or wrongly interpreted the intention behind the flag, then just ignore my approach. This API inconsistency manifested itself in a very minor problem that I've opted to fix on the Lua side for now: https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/9373.
- Lenguaje dominante
- C++
- Estrellas
- 22
- Forks
- 62
- Merge medio
- 1 d 3 h
- PR fusionados (30 d)
- 4
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic
-
SimpleGraphic v2.5.4 fails to start on Windows 7: kernel32.WaitOnAddress entry point not found Abierto
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
-
Dificultad 3/5 1-2 días Aptitud para principiantes 30/100
-
Dificultad 3/5 1-2 días Aptitud para principiantes 45/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 45/100
Todos los issues de PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
flutter-webrtc/flutter-webrtc#2206 ·
-
litertlm-android AAR ships no consumer ProGuard rules → "mid == null" SIGABRT in minified apps Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
google-ai-edge/LiteRT-LM#3739 ·
-
Component: GLib
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
brave/brave-browser#59300 ·
-
Mute ydb/tests/functional/dstool/test_canonical_requests.py.Test.test_group_take_snapshot in main Abiertoai_reviewed
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
ydb-platform/ydb#53974 · 3 comentarios ·