prqlc CLI and prqlc other than CLI should be separate crates or, the `cli` feature of prqlc should not be the default

Abierto
#4,946 6 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 3 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
30/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
rust
Área
cli

Línea de trabajo

Start by reading the prqlc crate’s feature and dependency configuration to see how the CLI dependencies affect downstream users’ MSRV. Compare the proposed crate split with disabling the cli feature by default, and check the project’s MSRV and CLI tests. Done means the project has chosen and implemented an approach that keeps the library’s MSRV independent of CLI dependencies.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

compiler enhancement needs-discussion

MSRV will become increasingly important as cargo will soon recognize the rust-version field and resolve dependencies.

Currently the prqlc crate is a required dependency of downstream packages that want to incorporate PRQL, but the MSRV of prqlc itself is pushed up by the MSRV of the cli feature dependency, which is not needed downstream.

MSRVs are not configurable on a per-feature basis, so as long as prqlc has the cli feature, prqlc's MSRVs are at risk of being raised by the cli feature.
This is especially troublesome for maintaining MSRV because the clap crate is not very conservative about MSRV (https://docs.rs/clap/latest/clap/#aspirations).

I think we should choose one of the following options to improve the situation here:

  1. Split prqlc into two crates, CLI and other.
    1. prqlc-cli and prqlc
    2. prqlc and prqlc-core (or something else)
  2. Remove the cli feature from prqlc default features. And ignore the MSRV of the cli feature.
Lenguaje dominante
Rust
Estrellas
10.9k
Forks
261
Merge medio
3 d 21 h
PR fusionados (30 d)
84

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de PRQL/prql

Todos los issues de PRQL/prql

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.