Update rdl2_json_exporter to include node outputs

Abierto
#299 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
58/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
cpp, json
Área
tooling

Línea de trabajo

Start with cmd/rdl2_cmd/rdl2_json_exporter and inspect how the exporter writes the existing attributes record and names its attribute types. Add output records containing the name, type, zero-based order, and uniform flag as described, then check the generated JSON and how its consumers handle unrecognized records.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

scene_rdl2: cmd/rdl2_cmd/rdl2_json_exporter needs to be updated to export information about outputs. The information will include name, type, position in the order, and whether the output is uniform or not.

Some Implementation Thoughts
  • add an "outputs" record which is a peer to "attributes"
  • add a record for each output name
  • in each record have
    "attrType" - using the same type names as in attributes. The "attr" prefix isn't quite perfect for an output but matching the naming in the "attributes" records to clarify they are the same seems valuable
    "uniform" - a boolean value to indicate whether the output is uniform or not. This could default to false and be left out for false.
    "order" - a positive integer to indicate the 0 based numbering of the output. The order is important so the output record of an evaluation can be properly interpreted.
Question

Will users of the json generated by rdl2_json_exporter be able to ignore the extra "outputs" record until they're updated to use the new record or will they error on the unrecognized record name?

Lenguaje dominante
CMake
Estrellas
4.7k
Forks
321
Merge medio
13 min
PR fusionados (30 d)
3

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenMoonRay/openmoonray

Todos los issues de OpenMoonRay/openmoonray

Issues similares

Más issues de DevTools

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.