Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

SignalToNoiseEstimatorMedian/MeanIterative: absolute "- 1" intensity offset in histogram binning and max_element comparator bug

Abierto
  • ¿Algo no está bien?
#10,521 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
cpp
Área
data

Línea de trabajo

Read SignalToNoiseEstimatorMedian.h and SignalToNoiseEstimatorMeanIterative.h, then inspect the related fix in PR #10504 and its comments. Run the existing estimator tests and add hand-computed S/N cases for spectra with maxInt <= 1. Update reference values and the CHANGELOG; done when both offsets and the comparator are corrected and the acceptance criteria pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
Operating System and Hardware

all

OpenMS Version

develop (after PR #10504)

Installation Method

Other

Bug Description

Follow-up to #10504 (SignalToNoiseEstimatorMedian out-of-bounds histogram access fix), as agreed in the PR comments between @jpfeuffer and @okohlbacher. These items were deliberately left out of that PR because they change binning for existing data.

1. Absolute - 1 offset in histogram binning (SignalToNoiseEstimatorMedian.h)

The bin index is computed as (peak.getIntensity() - 1) / bin_size. The - 1 looks like an older workaround to keep the maximum peak out of bin 100. After #10504 the bin index is clamped to 99, so the workaround is redundant. The offset is also absolute rather than relative to bin_size. This degrades the percentile (median) estimate when maxInt is around 1 or less.

To do:

  • Remove the offset, or make it relative to bin_size.
  • Evaluate the effect on existing data and tests. Binning, and so S/N values, will change, so update reference values and the CHANGELOG accordingly.
2. Same pattern in SignalToNoiseEstimatorMeanIterative.h

SignalToNoiseEstimatorMeanIterative.h has the same - 1 offset pattern.

3. max_element comparator bug in SignalToNoiseEstimatorMeanIterative.h

SignalToNoiseEstimatorMeanIterative.h has the same max_element comparator bug as the one fixed in the Median estimator. Check and fix it.

Acceptance criteria
  • The binning offset is no longer absolute in both estimators.
  • The max_element comparator is correct in MeanIterative.
  • Unit tests with hand-computed S/N cover small-intensity spectra (maxInt <= 1).
  • Behavior changes are noted in the CHANGELOG.
Lenguaje dominante
C++
Estrellas
623
Forks
441
Merge medio
19 h 18 min
PR fusionados (30 d)
271

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenMS/OpenMS

Todos los issues de OpenMS/OpenMS

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.