Improving Eurolite Mk2 Serial Number discovery/config

Abierto
#1,929 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
28/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
cpp

Línea de trabajo

No files or tests are named. Start by reviewing the existing Eurolite Mk2 serial-number configuration and startup behavior, then define how blank configuration values should trigger discovery and where discovered serials should be stored. Done means the workflow is specified and verified without requiring users to inspect logs or run lsusb.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Difficulty-Easy enhancement Language-C++ OpSys-All Priority-Low Type-DeviceSupport

I don't know what you think about this (maybe as a future enhancement for another PR):

  1. Start up OLAd in enable_eurolite_mk2
  2. If no (non-blank) eurolite_mk2_serial set (at startup), it adds each found one to the list
  3. So workflow wise you could plug in your Eurolite dongles, turn on the setting, run up OLA. Turn off the setting and plug in your other devices.
  4. Upsides you wouldn't have to read logs or find serial numbers via other methods
  5. Downsides some potential confusion if you don't follow the right workflow
  6. Alternative suggestion is do the same thing but put them in another key (e.g. discovered_eurolite_mk2_serial) which you could rename if required.

Originally posted by @peternewman in https://github.com/OpenLightingProject/ola/pull/1888#pullrequestreview-1587276197

I was just trying to think through how someone will use it. If like you I've got one Eurolite Mk2 and one Enttec, I find I can't use them both together unless I enable the serial number mode, but how do I find the serial number? If what's printed on the bottom of the unit is exactly what I need to type in, then perfect, but otherwise I was thinking OLA could effectively pull either any serials it finds, or the serials it found in the last run, into the config file, for you to copy and paste. Otherwise you need to either use lsusb or trawl through all the OLA logs or similar. But you're the one using the kit, does that make sense as a workflow or seem redundant?

Originally posted by @peternewman in https://github.com/OpenLightingProject/ola/issues/1888#issuecomment-1825690013

Someone would now indeed have to look at the OLA output or lsusb to find the serial number -- this is indeed not super user friendly. What would be really useful is if this could be configured on the web interface (including that the interface would show the serial numbers), but that's a whole different scope ;). What's currently implemented at least demonstrates the use of the serial number to solve the conflict. In fact, given that quite some modules conflict with each other, a future idea could even be to incorporate this in a more generic way so that the user would be shown the possible serial ids and select the right device for it.

Originally posted by @aroffringa in https://github.com/OpenLightingProject/ola/issues/1888#issuecomment-1890999788

Lenguaje dominante
C++
Estrellas
773
Forks
233
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenLightingProject/ola

Todos los issues de OpenLightingProject/ola

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.