create_docker_workspace never reuses locally-built images (tag mismatch with DockerDevWorkspace)

Abierto
#779 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
docker, python
Área
devops, tooling

Línea de trabajo

Empieza en benchmarks/utils/image_utils.py, en create_docker_workspace(), y compara después su fallback con DockerDevWorkspace._build_image_from_base() en openhands-workspace/openhands/workspace/docker/dev_workspace.py. Revisa benchmarks/utils/build_utils.py:ensure_local_image() y el llamador de SWE-Bench para comprobar el comportamiento de etiquetado esperado. Se considera terminado cuando un workspace local de Docker reutiliza el tag agent_server_image después del build de fallback, en lugar de volver a construirlo en los seis benchmarks afectados.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What's wrong

benchmarks/utils/image_utils.py:create_docker_workspace() pre-checks local_image_exists(agent_server_image) before falling back to building via the SDK's DockerDevWorkspace(base_image=..., target=...). But DockerDevWorkspace._build_image_from_base() (in openhands-workspace/openhands/workspace/docker/dev_workspace.py) builds via openhands.agent_server.docker.build.build(opts=BuildOptions(base_image=..., target=...)) without ever passing the agent_server_image tag. BuildOptions.image defaults to ghcr.io/openhands/agent-server (not this repo's EVAL_AGENT_SERVER_IMAGE = ghcr.io/openhands/eval-agent-server), and its tag is computed from base_tag (f"{short_sha}-{base_image_slug}") — a completely different naming scheme than whatever custom tag the calling benchmark computed.

Net effect: for every benchmark using create_docker_workspace with workspace_type=docker, if no pre-built image matches the expected tag, the fallback build tags its output under a name the next local_image_exists() check will never match — so local Docker runs always rebuild from scratch, even when an equivalent image was already built moments earlier in the same session.

Affected benchmarks

All current users of create_docker_workspace:

  • benchmarks/commit0/run_infer.py
  • benchmarks/gaia/run_infer.py
  • benchmarks/hybridgym_depsearch/run_infer.py
  • benchmarks/hybridgym_funcgen/run_infer.py
  • benchmarks/hybridgym_funclocalize/run_infer.py
  • benchmarks/hybridgym_issuelocalize/run_infer.py

Contrast with SWE-Bench

benchmarks/swebench/run_infer.py avoids this by using benchmarks/utils/build_utils.py:ensure_local_image() instead, which calls the benchmarks-side build_image() helper — that one builds and tags explicitly as target_image/custom_tag, matching what it just checked with local_image_exists().

Suggested fix

Either:

  1. Make create_docker_workspace's build fallback call ensure_local_image() (or build_image() directly) instead of DockerDevWorkspace, so the built tag matches the pre-checked one, or
  2. Pass image=/tag overrides into DockerDevWorkspace/BuildOptions so its output lands under the caller's expected agent_server_image tag.

Either way, this is local workspace_type=docker dev-loop ergonomics only — it doesn't affect CI-pushed remote images (workspace_type=remote), which use remote_image_exists() + pre-built GHCR tags directly.

Context

Found while reviewing #778 (dropping commit0's forked agent-layer Dockerfile) — commit0 was going to be brought in line with SWE-Bench's ensure_local_image pattern as part of that PR, but the fix was scoped out since it's a pre-existing, repo-wide gap shared by 6 benchmarks, not something specific to commit0's build pipeline.

Lenguaje dominante
Python
Estrellas
134
Forks
97
Merge medio
8 d 23 h
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenHands/benchmarks

Todos los issues de OpenHands/benchmarks

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.