ForceFreeStates - BUG - Fixed-boundary zero-crossing check can reject genuine Newcomb crossings

Abierto
  • ¿Algo no está bien?
#558 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 3 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
julia
Área
backend, testing-qa

Línea de trabajo

Start with src/ForceFreeStates/FixedBoundaryStability.jl:71-86 and compare its crossing check with the Fortran behavior documented in GPEC#292. Then run a fixed-boundary Solov'ev q0 scan at default and tightened tolerances, including a pole case. Done means Julia finds the same genuine crossings at both tolerance settings while still rejecting the pole.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

check_for_zero_crossings! (src/ForceFreeStates/FixedBoundaryStability.jl:71-86) is a line-for-line port of the Fortran ode_output_monitor test. When crit changes sign between two accepted ODE steps, it interpolates u linearly to the estimated root and accepts the crossing only if the midpoint value lies between the endpoints and |crit_mid| < 0.5*min(|crit|,|crit_prev|). Accepted steps can be long where crit is strongly nonlinear, so a genuine Newcomb zero crossing can fail this test and be discarded.

In the Fortran code this defect is reproduced and documented in GPEC#292: for fixed-boundary Solov'ev cases near q0 ≈ 1.03, DCON misses crossings at its default tolerances and finds them only after the tolerances are tightened. The Julia check has the same logic, so the same failure is expected, but I have not yet run the Julia q0 scan.

Simply relaxing the magnitude test is not the fix, because the sign change can also come from a pole of crit, which must not be counted. A robust check brackets the root, for example by bisection on the integrator's dense output, and distinguishes a zero (|crit| decreasing towards the bracket point) from a pole (|crit| growing).

Acceptance: a fixed-boundary Solov'ev q0 scan where Julia reports the same crossings at default and at tightened tolerances, with a pole case that is still rejected.

Chris&AI

Lenguaje dominante
Julia
Estrellas
11
Forks
7
Merge medio
3 d 22 h
PR fusionados (30 d)
70

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenFUSIONToolkit/GPEC

Todos los issues de OpenFUSIONToolkit/GPEC

Issues similares

Más issues de Julia

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.