Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Limit how often the same command can repeat

Abierto
  • ¿Algo no está bien?
#77 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust
Área
embedded-iot

Línea de trabajo

Start with docs/commands.md and the CommandRequirements::check entry point named in the issue; trace how commands are admitted before frames are built. Decide the guard’s scope, where it lives, and how each command declares an interval, then add host tests and document the rule. Done means every implemented command declares its interval and repeated commands are rejected as described.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

Part of the prerequisites for real commands (#75). Related: #73, #15.

Problem

Nothing stops the same command from reaching the car many times in a row. A stuck button, an app bug or a replayed message would send its frames to the bus again and again. #15 dedupes a redelivered message_id, but a stuck button sends a new message_id each time, so it doesn't help here.

Proposal

  • A minimum interval between two runs of the same command, checked right after the command requirements (CommandRequirements::check, see docs/commands.md) and before any frame is built.
  • A command inside the interval gets a failed CommandResponse with COMMAND_STATUS_CODE_REJECTED_UNAVAILABLE and a clear message, like any other rejection. Whether it is also reported unavailable until the interval has passed is to decide: it would grey the button out, but flickers after every press.
  • The interval is per command, set by each command's PR from how the car behaves (a door lock and a climate target temperature step don't need the same). Commands that are meant to be repeated quickly, such as stepping the target temperature, can use a short one or none.

To decide

  • Per command, per phone (source_device_id), or both?
  • Where the check lives: a small generic guard in core-interface next to the requirements, with each vehicle passing its intervals.
  • What counts as a run: any admitted command, or only one that was sent to the bus.

Done when

There is a guard with host tests, the docs describe the rule, and each implemented command declares its interval.

Lenguaje dominante
Rust
Estrellas
1
Forks
0
Merge medio
15 h 26 min
PR fusionados (30 d)
22

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

  • Sin Dockerfile ni archivo de Docker Compose
  • Sin plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenCarControls/firmware

Todos los issues de OpenCarControls/firmware

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.