[BUG][rust-axum] Range response codes (4XX, 5XX) generate code that does not compile

Abierto
#25,293 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

  • #25294 de @teovillanueva — cerrado sin fusionar

Evaluación

Dificultad
3/5
Tiempo estimado
Medio día
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
rust
Área
tooling

Línea de trabajo

Start with server-operation.mustache and the generated response enum for the provided OpenAPI declaration, then reproduce the failures by generating the rust-axum server and running cargo check in out. Done means ranged response variants preserve a concrete u16 status with optional body/headers as appropriate, and generated servers compile and build responses using the status() builder.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Description

When an operation declares a range response code (4XX, 5XX, ...), the rust-axum server generator emits code that does not compile. For range responses, server-operation.mustache renders

response.status::<u16>(body.code.parse().unwrap());  // 4XX

which assumes the response body has a code field (error[E0609]: no field 'code' on type 'models::Error'), fails when the response has no body (error[E0425]: cannot find value 'body' in this scope), and drops the builder returned by status() (error[E0382] once the other errors are worked around). The generated response enum also has no way for the implementation to choose the concrete status within the range.

openapi-generator version

master (7.27.0-SNAPSHOT, commit 30f13393)

OpenAPI declaration file content or url
openapi: 3.0.3
info:
  title: Range responses
  version: 1.0.0
paths:
  /pets/{petId}:
    get:
      operationId: getPet
      parameters:
        - name: petId
          in: path
          required: true
          schema:
            type: integer
            format: int64
      responses:
        "200":
          description: The pet
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/Pet"
        "4XX":
          description: Client error
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/Error"
        "5XX":
          description: Server error
components:
  schemas:
    Pet:
      type: object
      properties:
        name:
          type: string
    Error:
      type: object
      properties:
        message:
          type: string
Generation Details
java -jar openapi-generator-cli.jar generate -g rust-axum -i spec.yaml -o out
Steps to reproduce
  1. Generate the server with the spec above.
  2. Run cargo check in out.
  3. Compilation fails with E0609 (no field 'code' on type 'models::Error') for the 4XX arm and E0425 (cannot find value 'body') for the 5XX arm.
Related issues/PRs

None found.

Suggest a fix

Have range responses carry the status code: generate them as struct variants with a status: u16 field (plus body and headers as usual), e.g. Status4XX_ClientError { status: u16, body: models::Error }. The server then sets response.status(status), so the implementation picks the concrete code within the range.

Lenguaje dominante
Java
Estrellas
26.9k
Forks
7.8k
Merge medio
2 d 23 min
PR fusionados (30 d)
177

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenAPITools/openapi-generator

Todos los issues de OpenAPITools/openapi-generator

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.