[BUG][CSHARP] Multiple OAuth Flows generates C# code that doesn't compile
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Aptitud para principiantes
- 76/100
Línea de trabajo
Comienza con modules/openapi-generator/src/main/resources/csharp/libraries/generichost/DependencyInjectionTests.mustache cerca de la línea 79 y, a continuación, reproduce el comando de generación utilizando la especificación OpenAPI enlazada. Verifica que el archivo generado api-csharp/src/Org.OpenAPITools.Test/Api/DependencyInjectionTests.cs compile sin declaraciones duplicadas de OAuthToken.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Bug Report Checklist
- Have you provided a full/minimal spec to reproduce the issue?
- Have you validated the input using an OpenAPI validator?
- Have you tested with the latest master to confirm the issue still exists?
- No, but I linked the offending code below and it's still broken in master.
- Have you searched for related issues/PRs?
- What's the actual output vs expected output?
- [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description
When you have multiple OAuth flows defined in a specification, the generated C# code fails to compile due to a duplicate variable.
openapi-generator version
7.16.0
OpenAPI declaration file content or url
Example using the stock spec from Swagger Editor. Full spec - https://gist.github.com/scottbusche-usps/9ebaf3038984d40a61a6cf73da87b880
securitySchemes:
petstore_auth:
type: oauth2
flows:
clientCredentials:
tokenUrl: https://petstore3.swagger.io/oauth/token
scopes:
"write:pets": modify pets in your account
"read:pets": read your pets
implicit:
authorizationUrl: https://petstore3.swagger.io/oauth/authorize
scopes:
"write:pets": modify pets in your account
"read:pets": read your pets
Generation Details
java -jar openapi-generator-cli.jar generate -g csharp -o api-csharp -i oas.yaml --additional-properties=targetFramework=net8.0
I do not believe it matters on the targetFrameework version.
Steps to reproduce
Try to compile the code generated from the above command. Inside api-csharp/src/Org.OpenAPITools.Test/Api/DependencyInjectionTests.cs will be this block:
private readonly IHost _hostUsingConfigureWithAClient =
Host.CreateDefaultBuilder([]).ConfigureApi((context, services, options) =>
{
ApiKeyToken apiKeyToken1 = new("<token>", ClientUtils.ApiKeyHeader.Api_key, timeout: TimeSpan.FromSeconds(1));
options.AddTokens(apiKeyToken1);
OAuthToken oauthToken = new("token", timeout: TimeSpan.FromSeconds(1));
options.AddTokens(oauthToken);
// This oauthToken here has no index and duplicates the first one
OAuthToken oauthToken = new("token", timeout: TimeSpan.FromSeconds(1));
options.AddTokens(oauthToken);
options.AddApiHttpClients(client => client.BaseAddress = new Uri(ClientUtils.BASE_ADDRESS));
})
.Build();
Related issues/PRs
Nothing directly related that I could find.
Suggest a fix
This line appears to need to add {{-index}} suffix to the variable name:
https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/csharp/libraries/generichost/DependencyInjectionTests.mustache#L79
This looks pretty straight forward and happy to submit a PR.
- Lenguaje dominante
- Java
- Estrellas
- 26.8k
- Forks
- 7.7k
- Merge medio
- 1 d 10 h
- PR fusionados (30 d)
- 103
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de OpenAPITools/openapi-generator
-
Issue: Bug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 91/100
OpenAPITools/openapi-generator#24978 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
OpenAPITools/openapi-generator#24975 ·
-
Issue: Bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
OpenAPITools/openapi-generator#24859 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
OpenAPITools/openapi-generator#24852 · 1 comentario ·
-
[BUG][KOTLIN] Fails to compile after updating to 7.25.0 with useJackson3=false useSpringBoot4=true AbiertoIssue: Bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
OpenAPITools/openapi-generator#24842 · 1 comentario ·
Todos los issues de OpenAPITools/openapi-generator
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
infinispan/infinispan#18150 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
-
untriaged
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
opensearch-project/k-NN#3597 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100