Go client: no typed RunSweep wrapper — the sweep RPC is unreachable and the parity doc claims RPC coverage
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 58/100
Línea de trabajo
Read client/opensysml/client.go and client/opensysml/runs.go, then compare their request and response conversions with api/proto/sysml.proto and the handler in internal/frontend/grpc/sweep.go. Implement the typed client wrapper and preserve the response fields listed in the issue. Done means callers can invoke the sweep RPC through the Go client and receive its table and metadata; update docs/reference/client-parity.md to resolve its contradictory coverage claims.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Disclaimer, this issue was detected and written by an AI
Summary
The service has a RunSweep RPC that answers a table of run rows for a parameter
sweep. Every other client wraps it. client/opensysml has no RunSweep method at
all; a caller can only reach a sweep indirectly through RecordRun.
docs/reference/client-parity.md contradicts itself: "Every client exposes all 31
RPCs ... as typed calls", while the Open gaps table says "the package has no typed
RunSweep wrapper at all" (estimate about one day).
Service contract (already implemented)
api/proto/sysml.proto:
RunSweepRequest: model_hash, symbol_id (FQN of an analysis case or calc,
definition or usage), subject_symbol_id, positional arguments, named
named_arguments, ranges (SweepRange: parameter, start, end, step),
samples (draw uniformly; 0 steps; above 0 needs a seed and refuses a range with
a step), seed, engine.
RunSweepResponse: rows (SweepRow: inputs, outputs, verdicts,
elapsed_micros, error, failure_reason, evaluations), parameters,
sampled, seed, error, diagnostics, failure_reason, instances,
engine, strength, bounds.
The handler is internal/frontend/grpc/sweep.go:29; it requires
CapabilityVerification (not runs), and already checks ctx.Err() per
table at :143. A pre-run failure is a 200 with RunSweepResponse.error +
failure_reason; a failed row is a row, not a table error.
Current client state
client/opensysml/client.goClient:RunAction/RunMonteCarlo(RunRuns)
but noRunSweep.client/opensysml/runs.go:284—runRowsFromProtoalready decodes
[]*pb.SweepRow, but onlyInputs,Outputs,Verdicts,Error
(RunRowatruns.go:37).elapsed_micros,failure_reasonand
evaluationsare dropped.runs.go:439—RecordRange(parameter, start, end, step)already builds a
pb.SweepRange, so the range/value conversion exists.runs.go:517—Recording.Sweepuses the same decoder.
Required API
// SweepRange is one parameter stepped (or drawn) from start to end.
type SweepRange struct {
Parameter string
Start, End, Step Value // Step is nil for a sampled sweep
}
// Sweep is what a sweep answers: the table and the parameters it covered.
type Sweep struct {
Rows []RunRow
Parameters []string
Sampled bool
Seed uint64
Diagnostics []Diagnostic
Instances []*Instance // when the type already maps (analysis.go)
Engine string
Strength string
Bounds []Bound
}
type SweepOption func(*sweepOptions)
func SweepSubject(symbolID string) SweepOption
func SweepArguments(values ...Value) SweepOption
func SweepArgument(name string, value Value) SweepOption
func SweepSamples(rows int64) SweepOption
func SweepSeed(seed uint64) SweepOption
func SweepEngine(name string) SweepOption
// Sweep runs the analysis case or calc over the ranges and answers one row per
// run, in the service's order. Requires the verification capability.
func (c *client) Sweep(ctx context.Context, model *Model, symbolID string,
ranges []SweepRange, opts ...SweepOption) (*Sweep, error)
- Lenguaje dominante
- Go
- Estrellas
- 59
- Forks
- 20
- Merge medio
- 10 h 23 min
- PR fusionados (30 d)
- 897
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de Open-MBEE/OpenSysML
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
Los mantenedores suelen responder en 1 día
-
A model's parse is still paid cold in every process; the library record cache does not cover itAbierto
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
Los mantenedores suelen responder en 1 día
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
Los mantenedores suelen responder en 1 día
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 28/100
Los mantenedores suelen responder en 1 día
Todos los issues de Open-MBEE/OpenSysML
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
AvengeMedia/DankMaterialShell#4301 · 1 comentario ·
-
priority: p2 type: bug type: docs
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
googleapis/google-cloud-swift#1641 ·
Los mantenedores suelen responder en 1 día
-
needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
krakenhavoc/cmd_and_ctrl#5853 ·
Los mantenedores suelen responder en 1 día
-
flaky test: TestTRTAsyncPrefillFailures/transport reads the token load before prefillDone has released itPosiblemente ocupada @Jackmeson1 la tomó hoy. Abiertoarea/cicd area/gateway kind/misc
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
vllm-project/aibrix#3488 · 2 comentarios ·
Los mantenedores suelen responder en 1 día