OSDCloudRE: support creating the RE partition from a local / UNC ISO (without Azure)

Abierto
  • ¿Algo no está bien?
#402 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
56/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
powershell
Área
backend

Línea de trabajo

Start in Public/OSDCloud/OSDCloudRE.ps1 and compare Invoke-OSDCloudRE with Start-OSDCloudREAzure, following how the boot image is selected, downloaded, and used to size the partition. Check OSDeploy/OSD.psd1 for the export list. Done means a local or UNC ISO can use the new wrapper while the existing Azure flow still works; the issue gives no test file, so verify both paths using the module's existing checks.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Is your feature request related to a problem? Please describe.
OSDCloudRE can currently only be created from an ISO stored in Azure Storage (Start-OSDCloudREAzure → Invoke-OSDCloudRE). In environments where the boot ISO is already on the device (copied by a software distribution / DSC / Intune), on a file share, or where Azure Storage isn't available, there is no supported way to build OSDCloudRE. Invoke-OSDCloudRE has no parameters, stops when AzOSDCloudBootImage is empty, always downloads into C:\OSDCloud\Azure\..., and sizes the partition from the Azure blob (New-OSDCloudREVolume -IsoSize $Global:OSDCloudRE.AzOSDCloudBootImage.Length). So overriding BootImage via $Global:MyOSDCloudRE doesn't work either.

I currently work around this with a local copy of the OSDCloudRE functions, which I have to re-check on every OSD release.

Describe the solution you'd like
A small, backwards-compatible change in Public/OSDCloud/OSDCloudRE.ps1 (tested against 26.10.16.1):

  1. Invoke-OSDCloudRE gets an optional -LocalISOPath parameter (also settable via $Global:MyOSDCloudRE.LocalISOPath).
  2. If LocalISOPath is set, the Azure checks and download are skipped and BootImage is the local file. Otherwise the existing Azure flow is unchanged.
  3. The partition is sized from $Global:OSDCloudRE.BootImage.Length, which is the same value as the blob length in the Azure case.
  4. A new exported wrapper, Start-OSDCloudRELocal -ISOPath <path>, mirrors the admin / not-WinPE checks of Start-OSDCloudREAzure.
Start-OSDCloudRELocal -ISOPath 'D:\OSDCloud\OSDCloud.iso'
Start-OSDCloudRELocal -ISOPath '\\server\share\OSDCloud.iso'

The core of the change in Invoke-OSDCloudRE:

param (
    [System.String]
    #Path to an OSDCloud ISO on a local drive or UNC share. Azure Storage is not used when set
    $LocalISOPath
)
# ...
if (-not $Global:OSDCloudRE.LocalISOPath -and -not $Global:OSDCloudRE.AzOSDCloudBootImage) {
    Write-Warning "[$(Get-Date -format s)] A Boot Image is required to run this function"
    Break
}
# ...
#region Local ISO or Azure Storage Image Download
if ($Global:OSDCloudRE.LocalISOPath) {
    if (-not (Test-Path -Path $Global:OSDCloudRE.LocalISOPath -PathType Leaf)) {
        Write-Warning "[$(Get-Date -format s)] Unable to find $($Global:OSDCloudRE.LocalISOPath)"
        Break
    }
    $Global:OSDCloudRE.BootImage = Get-Item -Path $Global:OSDCloudRE.LocalISOPath -ErrorAction Stop | Select-Object -First 1
}
elseif ($Global:OSDCloudRE.AzOSDCloudBootImage) {
    # existing Azure download, unchanged
}
# ...
$Global:OSDCloudRE.Volume = New-OSDCloudREVolume -IsoSize $Global:OSDCloudRE.BootImage.Length -ErrorAction Stop

The full diff is about 80 lines, mostly the new Start-OSDCloudRELocal function and its help, plus one line in OSD.psd1 FunctionsToExport. I'm happy to open a PR if you're open to the idea, and to adjust the naming (e.g. Start-OSDCloudREISO / -ImagePath) to whatever fits the module best.

Describe alternatives you've considered

  • Maintaining a private copy of the OSDCloudRE functions with this change. This is what I do today, but it drifts from upstream with each release.
  • Uploading the ISO to Azure Storage just to satisfy Start-OSDCloudREAzure. That's not possible in offline or Azure-less environments, and it means downloading an ISO that is already on the device.
Lenguaje dominante
PowerShell
Estrellas
251
Forks
102
Merge medio
2 min
PR fusionados (30 d)
4

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OSDeploy/OSD

Todos los issues de OSDeploy/OSD

Issues similares

Más issues de Backend & API Design

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.