Thread milling: refuse a hole the program has not drilled yet (the mill is not centre-cutting)

Abierto
  • ¿Algo no está bien?
#992 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
42/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rust
Área
backend, devtools

Línea de trabajo

Start with machining2d::thread_ride, operation::drill_prior, and the existing drilling laws to trace how earlier operations leave stock under a threaded hole. Check how operation stamps are computed and how app tests pin generation and stale behavior. Done means an undrilled hole is refused by name, drilling first allows generation, reordering makes the thread stale and refuses, and the behavior is covered by an app test.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:2d area:sim bug effort:high P1 source:agent

Part of #894.

A thread mill is not centre-cutting, and the thread-milling ride (machining2d::thread_ride) feeds it down the hole's axis before the first lead-in arc. That is air only if an earlier operation opened the hole. Nothing checks it: the Thread operation generates and verifies clean on a part whose hole is modelled, even when the program holds no drilling operation before it and the stock at the hole is solid. The gouge laws read the part (the hole is in the model), so they see nothing; the centre-cutting audit (operation::plunge_solid, camcraft_motion::plunge_law) is not asked for this kind, and it reads the raw stock, which would refuse every thread.

Effect: forget the tap drill and the program plunges a thread mill into solid metal at plunge feed - a broken cutter, with no finding at generate, at verify or at the post gate.

Fix sketch: read the stock the setup's earlier operations leave standing (the prior grid the drilling laws already read, operation::drill_prior) under each threaded hole: the tool's full cylinder down the axis and the first pass's lead-in must fall through air. Refuse by name at generate ("the hole at (x, y) is not drilled yet - add a drilling operation before the thread") and digest the program ahead in the stamp, so reordering the operations marks the thread Stale.

Done means: a Thread operation with no drilled hole under it is refused by name; the same operation after a Drill of at least the tool's diameter generates; moving the Drill after the Thread turns it Stale and refuses; pinned by an app test. The milled Bore ride's axis entry gets the same reading or its own issue.

Lenguaje dominante
Rust
Estrellas
8
Forks
11
Merge medio
5 h 22 min
PR fusionados (30 d)
409

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de NeoTech/Camcraft

Todos los issues de NeoTech/Camcraft

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.