metagen: processDerivedClassRefs converts ancestor methods to properties using subclass selectors (phantom accessors in emitted metadata)

Abierto
  • ¿Algo no está bien?
#106 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
42/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
cpp, objective-c
Área
tooling

Línea de trabajo

Start in metadata-generator/src/IR/Class.cpp with processDerivedClassRefs, which calls convertMethodToPropertyIfNeeded in the wrong direction, and trace how ClassDecl::postProcessMembers invokes it. Confirm that an ancestor method record can be rewritten with a descendant's getter and setter selectors. Done means the ancestor keeps its own method record, such as NSView.autoscroll not gaining isAutoscroll, while superclass-to-subclass property propagation still works.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

processDerivedClassRefs in metadata-generator/src/IR/Class.cpp calls convertMethodToPropertyIfNeeded in the wrong direction: it rewrites an ancestor class's method record into a property using the derived class's getter/setter selectors. Generated metadata then declares members on classes that never implement those selectors.

ClassDecl::postProcessMembers iterates members of a class, then runs processDerivedClassRefs(member, derivedClassRefs), which invokes convertMethodToPropertyIfNeeded(member /* ancestor member */, cls->getMemberNamed(member.name) /* derived member */, false). Inside, when memberInSuperclass->kind == kMemberProperty — i.e. the derived class declared a property — the ancestor's method is converted to a property that copies memberInSuperclass->getterSelector/setterSelector, selectors that belong to the subclass and that the ancestor does not implement.

Observed in metadata.macos.arm64.nsmd (generated for the macosx SDK): a census found 213 phantom getters and 212 phantom setters. Example: NSView.autoscroll/NSClipView.autoscroll carry NSMatrix's isAutoscroll/setAutoscroll: — messaging a stock NSView with isAutoscroll raises -[NSView isAutoscroll]: unrecognized selector sent to instance.

Expected

A derived class's member declarations should not mutate the ancestor's member record; the property conversion should only flow superclass → subclass (which the postProcessMembers superclass walk already handles). Either drop the processDerivedClassRefs conversion or scope it so an ancestor never borrows a descendant's selectors.

Environment

  • NativeScript/runtimes main (verified identical at 5b697b39)
  • metadata-generator source + generated metadata.macos.*.nsmd
  • Impact is multiplied by the napi backend's unguarded selector dispatch — reading any phantom member aborts the process instead of raising a JS error (filed separately).
Lenguaje dominante
C++
Estrellas
27
Forks
4
Merge medio
5 d 11 h
PR fusionados (30 d)
12

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de NativeScript/runtimes

Todos los issues de NativeScript/runtimes

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.