Two cleanup/parsing nits: nvc_cfg NULL deref on OOM paths, sscanf %x into int

Abierto
#409 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
58/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c
Área
cli

Línea de trabajo

Read the cleanup paths in src/cli/configure.c and src/cli/list.c, then inspect matches_pci_format in src/cli/common.c. Guard the nvc_cfg cleanup when it is NULL and use unsigned variables for the %x conversions; done means both issues are corrected and the project builds cleanly.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

needs-triage

Two smaller hardening notes from the same audit pass that reported #408 — bundling them in one issue since neither is urgent on its own.

1. nvc_cfg can be NULL on the OOM cleanup paths

src/cli/configure.c:481 and src/cli/list.c:293 both do:

if ((nvc = libnvc.context_new()) == NULL || (nvc_cfg = libnvc.config_new()) == NULL) { warn(...); goto fail; }
...
fail:
        free(nvc_cfg->imex.chans);   /* nvc_cfg may be NULL here */

If context_new() fails (calloc returns NULL under memory pressure — runc hooks do run under container memory limits), the fail: path dereferences nvc_cfg->imex.chans with nvc_cfg == NULL. The sibling cleanups all guard their NULLs (libnvc.shutdown(nvc) etc. handle it); these two spots don't. Fix is the obvious guard:

-        free(nvc_cfg->imex.chans);
+        if (nvc_cfg != NULL) {
+            free(nvc_cfg->imex.chans);
+        }

Haven't reproduced at runtime (would need calloc failure injection), but the deref is clear from the code.

2. sscanf("%x") into int in matches_pci_format

src/cli/common.c:18:

sscanf(gpu, "%x:%02x:%02x.0", &domainid, &busid, &deviceid);

with int domainid, busid, deviceid. The upstream build log itself carries the gcc warning — %x wants unsigned int *, not int *. Input is attacker-controlled (NVIDIA_VISIBLE_DEVICES → --device=), and values ≥ INT_MAX are undefined per the C standard. In practice glibc's scanf just folds the value, and sanitized runs with ffffffff:99:99.0, ffffffffffffffff:99:99.0, etc. all produced clean "unknown device" rejections — no UBSan/ASan report, so this is paper UB rather than a live fault on glibc. Fix is to make the three variables unsigned int.

Both spotted during a full make debug (ASan/UBSan) audit pass of v1.20.2 (c7727e5); the sanitized end-to-end configure run itself was clean, so these are the only cleanup/parsing nits left standing from that pass besides #408.

Lenguaje dominante
C
Estrellas
1.1k
Forks
278
Merge medio
3 d 7 h
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de NVIDIA/libnvidia-container

Todos los issues de NVIDIA/libnvidia-container

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.