[Feature Enhancement]: Add a URL-returning overload of `getBlob(from:cid:)`

Abierto
  • ¿Algo no está bien?
#337 3 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
52/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
swift
Área
api, backend-api-design

Línea de trabajo

Start by reading the existing getBlob(from:cid:) implementation and the account PDS endpoint resolution discussed in issue #319. Add a synchronous overload that builds a URL using the resolved PDS endpoint and the supplied DID and CID; done means callers can obtain a URL without downloading the blob as Data. The issue names no relevant test file, so locate tests for getBlob and endpoint resolution before making the change.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement
Summary

getBlob(from:cid:) currently returns Data via an async throws call, which is appropriate for saving or exporting a blob. However, display-oriented APIs such as SwiftUI's AsyncImage and AVPlayer require a URL, not Data. A synchronous URL-building overload with the same name would cover this use case without an additional download.

Pain points

Callers that only need a URL for playback or image loading are forced to either:

  • Download the full blob as Data and convert it to UIImage/NSImage — wasting memory and blocking the async task before display can begin, or
  • Construct the URL manually from the PDS endpoint string, bypassing the typed API.

Concrete cases where a URL is required by the consuming API:

  • SwiftUI AsyncImage(url:) — displays a blob image (thumbnail, avatar stored as blob, etc.) with built-in lazy loading and caching. Accepts URL, not Data.
  • AVPlayer(url:) — streams a video blob for playback. AVPlayer must be initialised with a URL; passing Data is not supported.
Considered Alternatives

Keeping a raw helper that builds the URL from a PDS endpoint string — this works but lives outside the typed API and requires the caller to manage the endpoint separately.

Is this a breaking change?

No

Additional Context

The com.atproto.sync.getBlob lexicon specifies "output": { "encoding": "*/*" } and notes it is implemented by PDS. The URL-returning overload should therefore resolve the account's PDS endpoint rather than hardcoding a relay (see #319).

The new synchronous overload can construct the correct URL from the resolved PDS endpoint and the provided DID/CID query parameters.
Proposed addition:

public func getBlob(from accountDID: String, cid: String) -> URL?

Swift disambiguates the two overloads at the call site: the existing async throws form is chosen when the caller writes try await, and the new synchronous form is chosen when a URL? is expected without await.

Lenguaje dominante
Swift
Estrellas
226
Forks
40
Merge medio
5 h 8 min
PR fusionados (30 d)
3

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de MasterJ93/ATProtoKit

Todos los issues de MasterJ93/ATProtoKit

Issues similares

Más issues de Swift

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.