Front end: a resolution choice for the spectra shown

Abierto
  • ¿Algo no está bien?
#554 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
data-visualization, frontend

Línea de trabajo

Start with gui/src/solprop_gui/service/reduce.py and trace how the Overview, At this plane, scan spectrum maps, and spatial class maps call solprop's spectral readers and plotting functions. Check how the session stores the floor and spectral axis, and how plots and exports report settings. Done means a persistent resolution control reaches supported readers and the chosen resolution appears in plot readouts and exported figures.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: gui enhancement priority: low

The front end draws spectra at a fixed sampling, and offers no instrument resolution. It would help to choose the resolution of the spectra shown: to compare with a spectrometer's, or to see a broad continuum without its fine fringes.

Today

  • `gui/src/solprop_gui/service/reduce.py`: `Display.n_wavelength = 512` bins the spectrum along z (and `n_time = 2048` the pulse). These are display bins, not a resolution, and they aren't user-settable.
  • solprop's readers already take an instrument resolution: `processing.fields.get_spectral_density(..., resolution=)` (a full width at half maximum, in the abscissa's units), and `solprop.plotting.prop_2d` and `spec_1d` take one too. The front end passes none.

What it should do

  • The control: a Resolution control beside the spectral axis on the pages that draw a spectrum: Overview, At this plane, the scan's spectrum maps, and the spatial classes' spectral maps where their readers support it.
    • Choices: "Full" (as now), or a width in nm (wavelength axis) or THz (frequency axis).
    • The width is passed to solprop's readers as `resolution=`, so the smoothing is solprop's and matches what a script would get.
  • Keeping it: the choice persists per session, like the floor and the spectral axis.
  • Saying it: the plot's readout and the exported figure say the resolution used.
  • Optional: a choice of the number of display bins, for very broad or very fine spectra.

Found while testing the front end for 0.2 (#484).

Lenguaje dominante
Python
Estrellas
3
Forks
3
Merge medio
8 h 14 min
PR fusionados (30 d)
151

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de LupoLab/solprop

Todos los issues de LupoLab/solprop

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.