Import failure text reaches the History API unfiltered
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 50/100
Línea de trabajo
Start with DownloadProcessingJobProcessor.cs:346, DownloadProcessingJobProcessor.History.cs:65-76, and HistoryController.cs to trace how failure text reaches History responses. Then compare the existing LogRedaction.SanitizeFilePath and SanitizeText uses, and inspect the two log templates in DownloadImportService.cs:256 and :483. Done means path details are not exposed in History and the two log sites follow the repository's redaction pattern.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Filed from the batch G review of PRs 916 and 930. Pre-existing on canary a630572e;
both of those PRs widen it, neither creates it.
What happens
A failed file import writes its message straight into a History row, and History rows are
returned whole:
listenarr.infrastructure/Downloads/Processing/DownloadProcessingJobProcessor.cs:346
setsMessage = result.Message ?? $"{result.Action} completed".DownloadProcessingJobProcessor.History.cs:65-76putsresult.Message,result.SourcePath
andresult.FinalPathintodetails["FailedResults"], serialized intoHistory.Data.listenarr.api/Features/ActivityHistory/HistoryController.csreturns the entities with
Ok(history)andOk(new { entry, related }), soHistory.MessageandHistory.Data
are response fields.
ImportResult.ImportFailurebuilds its message as
$"Unable to perform {action} on {sourcePath} to {finalPath}", so the absolute source and
destination paths are already in that response today.ImportResult.Exceptionpasses the
caught exception's message through, and anIOExceptionfrom the file layer normally quotes
the path again and adds the platform error text.
Two adjacent log sites interpolate the same path into the message template rather than
passing it as a structured argument, so neither is sanitized and neither can be filtered by
field:listenarr.application/Downloads/Import/DownloadImportService.cs:256listenarr.application/Downloads/Import/DownloadImportService.cs:483
Everywhere else in the same area the repository already routes this text through
LogRedaction.SanitizeFilePathandLogRedaction.SanitizeText, includingFileMover's own
LogMutationandDownloadImportService.DirectoryOwnership.cs:277-280. These call sites are
the exception rather than the policy.
Why it matters
The History API is how the web UI draws the activity list, so this text is rendered to anyone
who can reach the instance. On a shared or reverse-proxied deployment the response describes
the host's directory layout, and on Windows the paths usually contain the account name.
How Readarr handles the same split
Readarr keeps the two audiences apart deliberately. ImportApprovedBooks.cs:271-306 logs the
exception object, so the log keeps everything, and then records a fixed classified sentence in
the user-visible result: "Failed to import book, permissions error", "Failed to import book,
root folder missing", "Failed to import book, destination already exists". The raw exception
text never reaches ImportResult.Errors (ImportResult.cs:30-37).
Suggested change
- Classify at the boundary. Map the failure to a short stable sentence for
History.Message,
the way Readarr does, and keep the exception object for the log. - If the raw text is kept, sanitize it on the way into the row and cap its length, matching
whatLogRedaction.SanitizeTextalready does for logs. - Independently, fix the two interpolated templates at
DownloadImportService.cs:256and
:483to pass the path as a structured argument throughLogRedaction.SanitizeFilePath.
Item 3 is small and self-contained and could land on its own.
Disclosure: drafted with Claude Code at my direction; I read the cited code at the stated commit and reviewed this before posting.
- Lenguaje dominante
- C#
- Estrellas
- 901
- Forks
- 70
- Merge medio
- 16 h 27 min
- PR fusionados (30 d)
- 60
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de Listenarrs/Listenarr
-
Search button on a book does not retry without the author when the full query finds nothingPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
Listenarrs/Listenarr#1173 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Listenarrs/Listenarr#1133 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
Listenarrs/Listenarr#1128 ·
Los mantenedores suelen responder en 1 día
-
Add New's search splits a title that contains "Series:", "Author:"… as if they were search keywordsAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
Listenarrs/Listenarr#1127 ·
Los mantenedores suelen responder en 1 día
-
p3
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
Listenarrs/Listenarr#971 ·
Los mantenedores suelen responder en 1 día
Todos los issues de Listenarrs/Listenarr
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
conductor-oss/csharp-sdk#183 ·
-
CreateNewLangProj throws when the default analysis writing system's ICU locale differs from its tagAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
-
kind/bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
unoplatform/uno#26555 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
CactuseSecurity/firewall-orchestrator#5739 ·
Los mantenedores suelen responder en 1 día
-
Bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
Los mantenedores suelen responder en 1 día