Consolidating my open PRs: 43 fixes in 9 bundles

Abierto
#1,014 5 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
1/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp
Área
backend

Línea de trabajo

This issue proposes replacing 34 open pull requests and eight additional fixes with nine subsystem bundles; it does not identify files or tests for an independent task. Read the linked bundle PRs and their commit-to-issue tables to understand the work. The proposed consolidation is complete when the bundles are reviewed and the superseded PRs are closed or split back out as maintainers decide.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

p4

I have a lot of open PRs here, and #739 explains how that volume slows you down. CONTRIBUTING.md asks for one fix per pull request, so I want to explain why I am about to go against that.

Several of these PRs touch the same code, and reviewing them one at a time hides how they interact. Putting them side by side found defects in four of them (below), and I think nine PRs should be less to triage than the thirty-four they replace.

So the plan is to replace 34 of my open PRs, plus 8 fixes I had not opened yet, with 9 PRs grouped by subsystem. One of the old PRs became two commits, which is why the total is 43. Each bundle keeps one commit per fix, built on canary at a630572e9, so you can review a bundle as one change or take only some of its fixes. I built each fix commit alone on canary. All but one build, and that one is called out in its bundle's description, along with the few extra commits that only make sense on top of the fixes they follow. Each description has a table mapping every commit to the PR or issue it came from, and lists any default or behaviour change next to what Readarr or Sonarr does.

Bundle What it covers Fixes Production lines
Naming Naming tokens matched case-insensitively on every path, series positions that are not plain numbers, culture-invariant number parsing 6 about 260
Log hygiene Webhook credentials kept out of logs, and the silent catch blocks from #928 2 about 340
URL base Serving under a sub-path behind a reverse proxy, the URL Base setting, Prowlarr import URLs 3 about 490
Download pipeline History rows attached to their book, retry-import, the finalization settings, retrying a failed file import, queue status 5 about 560
Search and indexers One indexer lookup per scoring batch, indexer age and size limits, MinimumSeeders, one query builder 3 about 580
Series and metadata Every series membership kept on every add path, SeriesAsin, Audible failures told apart from zero matches, contributor role suffixes 6 about 730
Download clients Circuit breaker, qBittorrent queue poll, refused and duplicate grabs, qBittorrent advanced settings, priorities, NZBGet warnings, 4.x paused states 8 about 810
Import and scan Chapter grouping, companion files, audio-only .mp4 in manual import, ASIN embedding 5 about 840
Quality profiles Encoder bitrates, Maximum Age, release labels, the Allowed flag, cutoff validation and UpgradeAllowed 5 about 1,080, plus one migration

The line counts leave out tests, which are most of the diff in seven of the nine bundles, and the generated migration files.

If it helps, this is the order I would suggest reviewing them in, smallest first: naming, log hygiene, URL base, download pipeline, search and indexers, series and metadata, download clients, import and scan, and quality profiles last, since it carries a migration and the most visible behaviour changes.

Other notes:

  • The four defects: #843 (with hardlinked imports, the ASIN write could change the download client's source file), #847 (manual search stopped treating a non-B0 ASIN as an ASIN), #1013 (a rescan brought the role suffix back) and #914 (once #843's fix is in, the cover-art write has the same hardlink problem). The bundles carry the fixes for the first three, and the closing note on each of those PRs says so. #914 stays a PR of its own, and I have added the guard to #914 itself.
  • I am holding four filesystem and recovery fixes (#866, #916, #930, #1011) until #993 lands, since they touch files it changes. They stay open as they are for now.
  • These stay as single PRs, because they are features, read better on their own, or overlap someone else's PR: #918, #914, #994, #943, #1012, #941, #924, #925, #954, #786, #849 and #871.
  • I am opening the nine bundle PRs alongside this issue and will link each one here in a comment. I'll leave the superseded PRs open for a week before closing each with a note pointing at its bundle, so if you would rather keep any of them separate, there is time to say so and I will split that bundle back out.

Disclosure: drafted with Claude Code at my direction; I read the cited code at the stated commit and reviewed this before posting.

Lenguaje dominante
C#
Estrellas
901
Forks
70
Merge medio
16 h 27 min
PR fusionados (30 d)
60

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Listenarrs/Listenarr

Todos los issues de Listenarrs/Listenarr

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.