Webhook "Test" returns bare 403 when the login screen is disabled

Abierto
#1,003 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp
Área
api

Línea de trabajo

Start with DiagnosticsController.cs and the UI path for Settings → Notifications, then trace how the test-notification endpoint handles the [LocalOrAdmin] response. The issue suggests displaying a useful explanation when the request is forbidden; check related issue #655 for the similar API-key behavior. Done when the failure explains the login-screen or local/API-key requirement and the UI presents that message.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

p3

Version: canary-1.3.4 (ghcr.io/listenarrs/listenarr), Docker on Unraid, login screen disabled (default)

What happens
In Settings → Notifications, clicking Test on a webhook fails with:

{"type":"https://tools.ietf.org/html/rfc9110#section-15.5.4","title":"Forbidden","status":403,"traceId":"..."}

It fails identically for any webhook URL, including a public one, and nothing is written to the container log.

Cause
POST /api/v1/diagnostics/test-notification is marked [LocalOrAdmin] (DiagnosticsController.cs). With authentication disabled, no caller is an authenticated admin, so anyone not on loopback (i.e. every browser reaching the container over the LAN) gets a 403.

Why it's a problem

  • The UI shows the raw error with no hint that enabling the login screen fixes it. It looks like a broken webhook or ntfy setup.
  • Enabling the login screen and creating an admin user makes the Test work, so the guard behaves as coded. The failure is silent and misleading.

Suggested fix
Return a message like "Testing webhooks requires the login screen to be enabled or a local/API-key request", and have the UI show it. Related: #655 (same pattern for the API-key endpoints, where the UI also hides the 403).

Lenguaje dominante
C#
Estrellas
901
Forks
70
Merge medio
16 h 27 min
PR fusionados (30 d)
60

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Listenarrs/Listenarr

Todos los issues de Listenarrs/Listenarr

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.