Design discussion
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
Línea de trabajo
Comienza con src/NestedNumbers.jl y examples/usage_demo.jl, y luego revisa los draft PRs enlazados y el contexto de Reactant y Discourse. El issue busca la crítica de la comunidad sobre el nombre del paquete, la jerarquía de tipos y el enfoque general, en lugar de especificar un cambio acotado; para darlo por terminado sería necesario acordar una dirección o una propuesta concreta de seguimiento.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
We have some number types in the Julia ecosystem that are "a bit special". The one's I have encountered most often are quantities (numbers with units), opaque/traced/symbolic numbers (value not accessible at all) and numbers that are "remote", i.e. that live on a separate compute-node/device/system (value accessible only with substantial latency).
Making such numbers subtypes of Real and Integer is tricky, dispatch wise, but also semantically not ideal - one might argue that a traced number with a real value is not actually a real number itself - I can operate on it, but I can't compare values and make a branching decision based on it (at least not during tracing). Likewise, a real number with a unit is clearly not a real number itself. On the other hand, user code often needs to restrict numerical type, both for semtantic and dispatch reasons - a function that will behave wrong for complex values should ideally not use Number at the argument type.
Also see https://github.com/EnzymeAD/Reactant.jl/issues/1570 and https://discourse.julialang.org/t/flexunits-jl-0-3-0-support-for-unitful-like-inference/134903/38 for context.
NestedNumbers is an attempt to create a bridge here - a super-lightweight package that user code can depend on and use for dispatch, while only minimal changes are required for unit packages or packages that use traced numbers like Reactant.
See the NestedNumbers demo, which requires these draft PRs:
- https://github.com/JuliaPhysics/Unitful.jl/pull/837
- https://github.com/Deduction42/FlexUnits.jl/pull/52
- https://github.com/JuliaPhysics/DynamicQuantities.jl/pull/198
- https://github.com/EnzymeAD/Reactant.jl/pull/2434
The final approach should ideally involve UnitsBase as well.
(Note that Reactant doesn't seem to work with unitful numbers in general yet, so the demo doesn't show a combination of both. )
The basic approach is this: NestedNumbers defines
- Abstract types like
OpaqueNumber{T}RemoteNumber{T}QuantityNumber{T}that packages that define number types can subtype. - Union typedefs like
AReal,AInteger,AComplex,ABoolandQReal,QInteger,QComplex,QBoolfor user/downstream code to dispatch on.
It's all in the single short source file.
Everyone involved/interested is more than welcome to comment and critique here, propose radical changes (feel free to open PRs), etc. NestedNumbers is not registered yet on purpose, everything is up for change including the package name. This is an attempt to see if this kind of approach can work and would be acceptable, and it's meant to involve the whole community.
- Lenguaje dominante
- Julia
- Estrellas
- 2
- Forks
- 0
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Preparar el entorno
Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Issues similares
-
add-on doc enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
JuliaGraphics/ColorTypes.jl#344 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
-
`enzymexla.linalg.lu` lowering fails for a tall matrix: the permutation is built with the pivot typeAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
EnzymeAD/Enzyme-JAX#3286 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 90/100
SciML/LinearSolve.jl#1359 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
EnzymeAD/ReactantNitro.jl#13 ·