Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

BL-33: On-chain deployment drift check — verify foundry/deployments/<network>.json still matches the chain

Abierto
#244 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@robertocarlous ya está trabajando en esto.

Desde el 15/10/2026.

  • #254 de @robertocarlous — abierto

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python, solidity

Línea de trabajo

Read foundry/deployments/<network>.json, dincli/cli/system.py around import_deployments, and Developer/BACK_LOG.md BL-33 to understand the deployment records. Then inspect the Foundry scripts and contract interfaces for the listed proxy slots, ownership, wiring, and slasher checks. Done means a read-only verifier reports expected and actual values for each recorded contract and exits non-zero on any drift.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Approved enhancement

Summary

Nothing currently verifies that foundry/deployments/<network>.json (and the din_info that dincli system import-deployments writes) still matches what is actually deployed. A fresh clone, a failed upgrade, or a manual intervention can leave the recorded addresses and the chain out of sync with no visible signal.

Proposal

A read-only check — either a forge script (script/VerifyDeployment.s.sol) or a new dincli system verify-deployment subcommand — that for each contract recorded in the deployments JSON reports OK or DRIFT with expected vs. actual values for:

  1. Proxy implementation slot — read EIP-1967 bytes32(uint256(keccak256("eip1967.proxy.implementation")) - 1) and compare against the recorded implementation address.
  2. Proxy admin slot — read EIP-1967 bytes32(uint256(keccak256("eip1967.proxy.admin")) - 1) and compare against the recorded proxyAdmin* address.
  3. Runtime code hash — keccak256(extcode(implementation)) vs. keccak256 of the current forge build artifact's deployedBytecode (immutables masked out via forge inspect --json).
  4. Owner / DIN-Representative addresses — call owner() on each ownable contract and compare.
  5. Wiring — DinCoordinator ↔ DinToken / DinValidatorStake / DinModelRegistry / fee router / treasury links, and slasher authorizations on DinValidatorStake.

Exit non-zero on any DRIFT row.

When to run

  • Before every DevNet 3.0 deploy.
  • After every UpgradePlatform.s.sol run.
  • As an optional CI step on pushes that touch foundry/script/.

Limitations

This check only covers what the deployments JSON records. A clean run does not prove nothing else was deployed or authorized outside that file.

References

  • Developer/BACK_LOG.md BL-33
  • foundry/deployments/ (network JSON files)
  • dincli/cli/system.py import_deployments — the import side that reads the same JSON
  • Terraform state-vs-live drift pattern (Osomudeya/devops-scripting-labs 03-drift-detection, reviewed 2026-10-02)
Lenguaje dominante
Python
Estrellas
4
Forks
7
Merge medio
3 d 4 h
PR fusionados (30 d)
34

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de InfiniteZeroFoundation/DevNet

Todos los issues de InfiniteZeroFoundation/DevNet

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.