Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Formatter collapses unequal legal indentation levels and emits unparseable source

Abierto
  • ¿Algo no está bien?
#1,246 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
74/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c
Área
compilers

Línea de trabajo

Start with src/fmt.c:352–382 and docs/SPEC.md:69, then run the supplied indent.eigs commands after a fresh default make build. Exercise the reproducer and the listed unequal-increment, sibling, dedent, and 2-/4-space cases; done means formatted programs remain parseable, preserve execution output, and satisfy the stated regression checks.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:lint-tooling bug found-by:code-review

Formatting a valid nested block can collapse two different indentation levels and make the program fail to parse. --fmt returns success; --fmt --write would replace the working source with that result. The LSP formatting handler uses the same formatter.

Reproduction

Save this as indent.eigs. The two indented lines use four and six spaces, respectively:

if 1:
    if 1:
      print of 7
print of 9

eigenscript indent.eigs
eigenscript --fmt indent.eigs > formatted.eigs
eigenscript formatted.eigs

Original: exit 0, stdout 7\n9\n. Formatter: exit 0, but emits:

if 1:
    if 1:
    print of 7
print of 9

The result exits 1 with Parse error line 3:5: expected indent, got identifier ('print').

Cause and contract

docs/SPEC.md:69 requires consistent indentation within a block, not equal increments between blocks. The original program executes successfully.

src/fmt.c:352–382 finds the smallest positive indentation (4 here), then computes level = indents[i] / min_indent. Integer division maps both 4 and 6 to depth 1. Formatting needs to preserve the actual nesting/dedent structure instead of deriving it from one global width.

Regression acceptance

  • Formatting the reproducer preserves successful execution and its exact output.
  • Cover unequal indentation increments, sibling blocks, dedents, and ordinary 2-/4-space inputs.
  • Assert parseability and output after applying the formatter; idempotence alone cannot detect this corruption.

Distinct from #729/#750, which address splitting operators and keeping the operator table synchronized.

Verification

Confirmed with a fresh default make build of b91768e23c5a874a64e76e4af9ab291e6aa49983 in a clean isolated worktree. The original, formatter, and transformed program were executed separately with inherited EIGS_* variables removed; exit status and output were captured for each.

Lenguaje dominante
C
Estrellas
3
Forks
7
Merge medio
4 h 7 min
PR fusionados (30 d)
112

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de InauguralSystems/EigenScript

Todos los issues de InauguralSystems/EigenScript

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.