Self-hosted cluster removal: retry a logout that failed, or one skipped because the cluster couldn't be read

Abierto
  • ¿Algo no está bien?
#1,967 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript
Área
authentication, frontend

Línea de trabajo

Start with the best-effort design and its trade-offs in src/features/cluster/DESIGN.md, then find the cluster removal path and its one-attempt logout call. Decide where a credential-free "logout owed" marker is stored and when the next app sign-out checks it, and how the cluster read is retried. Done means a failed logout is retried on the next app sign-out, and the stored credential is kept until that retry.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What happens

After #1966, removing a self-hosted cluster from Studio sends one best-effort logout to its server and forgets the remembered sign-ins for the cluster and its instances. "Best effort" was the call on #1954: one attempt, a short timeout, and the removal never waits on it. That leaves two cases where the server-side session outlives the removal:

  1. The logout fails or times out. Studio has already forgotten the sign-in, so nothing retries it, not even a later app sign-out. A server that's unreachable when you remove it keeps that session until it expires.
  2. Studio can't read the cluster record at removal. Both reads, alongside and after the DELETE, failed. Studio can't tell whether the cluster was self-hosted, so it sends no logout. The forgetting happens on the next visit to one of the cluster's pages, as #1954 does for Fabric clusters.

Both are accepted costs of the best-effort design, recorded in src/features/cluster/DESIGN.md. Neither touches another cluster's credentials.

Possible improvement

Keep a small "logout owed" marker after a failed logout, holding no credential, so the next app sign-out retries it once. For case 2, retry the cluster read once later. Either way the stored credential has to stay until the retry, which is the trade-off the best-effort call avoided.

Review-Deferral: 360de88dc2418237 severity=minor category=security
Review-Deferral: 85883ef1b2f4b7a1 severity=nit category=reliability

Raised by the cross-model review of #1966 (#1931).

🤖 Generated by Anthropic Claude Code (Claude Opus 5.5); posted via @dawsontoth.

Lenguaje dominante
TypeScript
Estrellas
5
Forks
4
Merge medio
1 d 19 h
PR fusionados (30 d)
144

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de HarperFast/studio

Todos los issues de HarperFast/studio

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.