Document commit signing: rationale, setup, and org-wide enforcement
@Ethan-Arrowood ya está trabajando en esto.
Desde el 10/7/2026.
Evaluación
Este issue todavía no se ha evaluado.
Descripción
Summary
Write a commit signing guideline doc. We want to enforce commit signing across the org — all commits to all HarperFast repos, with public-facing OSS repos as the highest priority, should be signed.
Doc outline
The doc should be structured in this order:
1. Why commit signing matters
Open with the rationale: signed commits cryptographically verify that a commit actually came from the person it claims to be from. Cover the threat model briefly — author spoofing (anyone can set user.name/user.email to anything), supply chain integrity for our OSS consumers, and the "Verified" badge as a trust signal on public repos.
2. How to set it up
Link out to setup resources rather than duplicating them:
- GitHub: About commit signature verification
- GitHub: Signing commits
- SSH key signing (the lowest-friction option for most people): Telling Git about your SSH key
- GPG setup for those who prefer it
- Note on signing via the GitHub web UI (web-created commits are automatically signed by GitHub)
3. How we enforce it
Link to the enforcement mechanisms and document which ones we use:
- Org-level: rulesets at the organization level with the "Require signed commits" rule
- Repo-level: branch protection / repo rulesets requiring signed commits on default branches
- Document the actual settings we apply so repo admins can verify their repo is compliant
4. AI agent workflows
Platform enforcement (rulesets, CI, hooks) is the backstop, but AI agents are a major producer of commits and a major reviewer of PRs — the guideline should be embedded in agent workflows too, especially in the window before hard enforcement is rolled out:
- Producing commits: skills / agent instructions (e.g. in the
skillsrepo,CLAUDE.md/AGENTS.mdconventions) should instruct agents that commits they author must be signed — verify the environment's signing config (git config commit.gpgsign, signing key present) before committing, and surface a warning rather than silently producing unsigned commits. - Reviewing PRs: PR-review skills should include a commit check step — flag unsigned/unverified commits in review output. This gives us soft enforcement via agent review before org rulesets are turned on.
The doc should note this pattern; actually updating the individual skills can be follow-up work.
5. Effective date
Short closing section: this policy was adopted in July 2026. Enforcement applies to commits from this point onward — historical unsigned commits are grandfathered in and do not need to be rewritten. Only new commits are required to pass signature verification.
Acceptance criteria
- Doc added to this repo following the sections above
- Enforcement settings (org ruleset and/or repo-level guidance) documented
- AI agent workflow guidance included (agents sign their commits; review skills check for signatures)
- Effective date (July 2026, forward-looking only) stated
- Lenguaje dominante
- JavaScript
- Estrellas
- 3
- Forks
- 0
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de HarperFast/code-guidelines
-
Define commit standards: authorship, AI attribution, and trailersQuizá libre de nuevo @Ethan-Arrowood la tomó hace 84 días y no hay ningún pull request abierto. Abierto
HarperFast/code-guidelines#13 · 1 asignado ·
Todos los issues de HarperFast/code-guidelines
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
CopilotKit/aimock#491 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
keyxmakerx/Chronicle#967 ·
Los mantenedores suelen responder en 1 día
-
good first issue hacktoberfest
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
RogueAlg0/taken#386 · 3 comentarios ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
DietrichGebert/ponytail#978 ·
Los mantenedores suelen responder en 2 días
-
bug component: bulk editor support
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Yoast/wordpress-seo#23669 ·
Los mantenedores suelen responder en 3 días