Bug Report/UX Issue: Merging prefers merged contents colours

Abierto
#4,730 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
Medio día
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust

Línea de trabajo

The report points at the Merge node in the node graph as the place where fill and stroke are resolved, with the bottom input's values overriding the top input's. Reproduce it by setting a fill or stroke colour on the top input and checking the merged result, then find where the Merge node chooses between its inputs. Done means agreement with maintainers on whether the top or bottom input should win, and a fix that matches that decision. The thread has not settled whether this is a bug or a UX question, so confirm that first.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Version: Development branch (https://dev.graphite.art/)
Browser: Firefox

Personally not sure if this is a bug or a UX problem. Here is a video recording:

https://github.com/user-attachments/assets/29053c91-5dbc-4204-a07d-f5b112a63977

The same issue applies to the stroke as well.

Upon inspection of the node graph to see where it was getting the colour from:

Image

I found the reason is that the merge node prefers the bottom input's fill and stroke colour over the original top input's fill and stroke colour, which isn't changed when changing the colour of the stroke or fill through the method shown in the video. Forcing the user to either move up the fill and stroke manually, or disabling and enabling the fill and stroke so it is forced pasted the merge node in the order.

If this is a duplicate, I misunderstood something, or someone thinks of a more accurate title please let me know. (feel free to ping me on discord as I am more likely to see it.)

Lenguaje dominante
Rust
Estrellas
27.8k
Forks
1.3k
Merge medio
10 h 53 min
PR fusionados (30 d)
195

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de GraphiteEditor/Graphite

Todos los issues de GraphiteEditor/Graphite

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.