Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Home screen contact shortcut stays after the contact is deleted (and keeps the old name after a rename)

Abierto
  • ¿Algo no está bien?
#633 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
58/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
android, kotlin
Área
mobile

Línea de trabajo

Start with shortcut creation in app/src/main/kotlin/org/fossify/contacts/adapters/ContactsAdapter.kt and the missing-contact handling in app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt. Trace contact save and delete flows to see where pinned shortcuts can be updated or disabled, then check existing shortcut related tests. Done means a renamed contact's shortcut shows the new name and a deleted contact's shortcut no longer opens an empty screen.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug needs triage
Checklist
  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.
Affected app version

1.6.0

Affected Android/Custom ROM version

android 16

Affected device model

Xiaomi 17 promax

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug
  1. Create a contact Bob. In the contact list, long-press Bob → ⋮ → Create shortcut → Add automatically. A Bob shortcut appears on the home screen.
  2. In Contacts, open Bob → Edit, rename him to Robert and save.
  3. Go to the home screen: the shortcut is still called Bob. Tapping it opens Robert correctly.
  4. Delete Robert in Contacts (trash icon → Yes). The contact list no longer has him.
  5. Go to the home screen and tap the Bob shortcut again.
Expected behavior

Both changes are made in Contacts itself, which also created the shortcut, so the app knows about them:

  • after the delete (step 4), the shortcut is disabled or removed (Android then shows a "contact was deleted"-style message instead of opening it);
  • after the rename (step 2), the shortcut label is updated to Robert.
Actual behavior

After the delete, the Bob shortcut stays on the home screen. Tapping it opens an empty contact screen, which closes right away and returns to the launcher, without any message.
After the rename, the shortcut keeps the old label Bob (it still opens the right contact).

Screenshots/Screen recordings

No response

Additional information

The shortcut is created with the contact name at that time as label and contact.hashCode() as its id:
https://github.com/FossifyOrg/Contacts/blob/8bbc84014f776b2199136a500799c21425ff0fe8/app/src/main/kotlin/org/fossify/contacts/adapters/ContactsAdapter.kt#L317-L338

Nothing in the app calls ShortcutManager.updateShortcuts() or disableShortcuts(), so saving an edit or deleting a contact never touches the pinned shortcut. Because Contact is a data class, its hashCode() changes when the contact is edited, so the app could not find the shortcut again even if it tried. When the contact is gone, ViewContactActivity just finishes (the "unknown error" toast did not show up for me):
https://github.com/FossifyOrg/Contacts/blob/8bbc84014f776b2199136a500799c21425ff0fe8/app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt#L166-L175

Possible fix: use a stable shortcut id (e.g. the contact id), then call updateShortcuts() after saving and disableShortcuts(ids, message) after deleting a contact.

Lenguaje dominante
Kotlin
Estrellas
917
Forks
73
Merge medio
1 d 16 h
PR fusionados (30 d)
8

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de FossifyOrg/Contacts

Todos los issues de FossifyOrg/Contacts

Issues similares

Más issues de Kotlin

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.