`ce-polish` refuses a concurrent `start` with a context-free error, dropping the holder PID and the `EEXIST` cause

Abierto Apto para principiantes
#2,085 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
78/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript, node.js
Área
backend, cli

Línea de trabajo

Lee en skills/ce-polish/scripts/live-endpoint.js las líneas 903–918, alrededor de acquireStartLock, y el manejo de errores en main(), alrededor de la línea 2835. Reproduce el rechazo con un PID activo en state/start.lock; luego actualiza el error para que incluya el PID del titular y la ruta del bloqueo, y conserva el EEXIST capturado como causa. Se considera terminado cuando la CLI identifica al titular y el error conserva su causa.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Environment

  • EveryInc/compound-engineering-plugin at commit 122f9f90330df0b54da865e12cbecb81ffd0ae53
  • skills/ce-polish/scripts/live-endpoint.js, acquireStartLock lines 903-918
  • Node.js 24, Windows/macOS/Linux

Summary

A second start for the same root is correctly refused while another live start holds state/start.lock, but the refusal is reported as the bare sentence Another \start` for this root is in progress. The catch block that detects the held lock throws a new Error: the EEXISTit caught (which carries the lock path) is not attached ascause, and the holder PID it has just read from the lock file is not included. main()prints onlyerror.message`, so nothing else reaches the operator.

The refusal itself is correct and documented. With several roots or agents running, the message does not say which process holds the lock, and stop --root does not clear state/start.lock.

Root cause

// skills/ce-polish/scripts/live-endpoint.js:903-918
function acquireStartLock(options) {
  const lockPath = path.join(options.stateDir, "start.lock")
  let lockFd
  try {
    lockFd = fs.openSync(lockPath, "wx", 0o600)
  } catch (error) {
    if (error.code !== "EEXIST") throw error
    const holder = Number(fs.readFileSync(lockPath, "utf8")) || null
    if (holder && processAlive(holder)) throw new Error("Another `start` for this root is in progress")
    ...

The replacement Error keeps neither error nor holder nor lockPath, although all three are available at the throw.

Affected code

skills/ce-polish/scripts/live-endpoint.js, line 911 (the throw inside acquireStartLock).

Reproduction

  1. Create a root with a state/start.lock containing the PID of a live process (this is the state a running start leaves).
  2. Run the documented command against that root:
node skills/ce-polish/scripts/live-endpoint.js start --root <root>

Observed on Node 24.21.0:

$ node skills/ce-polish/scripts/live-endpoint.js start --root <root>
Another `start` for this root is in progress
$ echo $?
1

The caught object is EEXIST: file already exists, open '<root>/state/start.lock' with code, syscall, errno and path; it is not reachable from the thrown error. The thrown error has only stack and message, and its own-property list is ["stack","message"] (no cause). The PID read at line 910 is discarded. A clean run without any instrumentation shows the same stderr and exit code.

A control that changes only line 911 to include the holder and the lock path and to pass { cause: error } prints Another \start` for this root is in progress (holder pid 28648, lock /state/start.lock)and exposes theEEXISTonerror.cause`.

Expected behavior

The refusal should keep its wording but also identify the blocking process, and the caught EEXIST should be chained as cause:

if (holder && processAlive(holder)) {
  throw new Error(
    `Another \`start\` for this root is in progress (holder pid ${holder}, lock ${lockPath})`,
    { cause: error },
  )
}

Actual behavior

The thrown error contains only the generic sentence. The EEXIST details, the lock path and the holder PID are all dropped, and main() at line 2835 prints only error.message, so an operator cannot identify the process that holds the lock.

Suggested fix

Attach the holder and the cause as above. If terse CLI output is preferred, keep the short message but print error.cause (or error.stack) under a debug flag in main(), so the information remains available instead of being discarded at the boundary.

Lenguaje dominante
TypeScript
Estrellas
25.6k
Forks
2.1k
Merge medio
3 h 57 min
PR fusionados (30 d)
170

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de EveryInc/compound-engineering-plugin

Todos los issues de EveryInc/compound-engineering-plugin

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.