Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

DI registrations create separate backing stores when tracing is disabled

Abierto
  • ¿Algo no está bien?
#610 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 7 días

@nmummau ya está trabajando en esto.

Desde el 14/10/2026.

  • #622 de @nmummau — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
15/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
csharp
Área
backend

Línea de trabajo

The issue names StoreRegistrationTests.cs under src/Extensions/test/Eventuous.Tests.DependencyInjection and describes the affected AddEventStore, AddEventReaderWriter, AddEventReader, and AddEventWriter APIs. Start by reviewing the existing regression tests and tracing how registrations resolve shared stores with diagnostics enabled and disabled. Done means the listed host, factory, scope, and diagnostics cases pass; the issue says an implementation is already committed locally, so check whether that work is still available before starting.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Related test issue

Discovered while implementing #608 — event-store dependency injection coverage.

Problem

With EventuousDiagnostics disabled, store registration methods register implementations or factories separately for each interface. Each interface therefore gets its own singleton rather than sharing one backing instance.

A successful append through IEventWriter can be followed by StreamNotFound when the same stream is read through IEventReader. This is reproducible with the stateful InMemoryEventStore; it is not a claim that persistent providers lose stored data. Factories can also run more than once, and standalone reader/writer registrations can ignore an already registered concrete store.

Affected APIs include the generic and factory overloads of AddEventStore<T>, AddEventReaderWriter<T>, and separately composed AddEventReader<T> / AddEventWriter<T>.

Reproduction

  1. Disable diagnostics, preserving the previous setting for restoration afterward.
  2. Build a host with services.AddEventStore<InMemoryEventStore>().
  3. Resolve IEventWriter and IEventReader from that host.
  4. Append an event to a new stream through the writer.
  5. Read that stream through the reader.

Actual: the read throws StreamNotFound because the interfaces resolve to different stores.

Expected: all interfaces registered for the same implementation share one backing singleton. Changing tracing configuration must not change which events are visible.

Fix and acceptance criteria

  • Register the concrete implementation or factory once, then resolve interface aliases from that singleton.
  • Verify append/read behavior through a real host for store, combined reader/writer, and separately registered reader/writer APIs.
  • Cover generic and factory overloads with tracing enabled and disabled.
  • Factories are invoked once for the shared instance, and interface resolutions remain singleton across scopes.
  • Standalone reader/writer registrations reuse a pre-registered concrete instance without invoking a replacement factory.
  • Tests restore the process-wide diagnostics setting and cannot race with other tests that observe it.

Existing regression tests and implementation

StoreRegistrationTests.cs in src/Extensions/test/Eventuous.Tests.DependencyInjection contains:

  • WrittenEventsAreVisibleThroughEveryRegisteredInterface
  • StandaloneRegistrationUsesTheExistingBackingStore
  • The tracing-disabled cases of RepeatedRegistrationKeepsOneServiceAndOneFactory

These scenarios failed before the production fix. The complete DI project passes all 31 tests on .NET 10 after the fixes for this issue and the companion registration issue.

An implementation is already committed locally on fix/issue-608-store-registrations, commit df3dbe48. It also fixes duplicate registrations and overridden services; this draft does not imply the fix has been published or merged.

Lenguaje dominante
C#
Estrellas
512
Forks
99
Merge medio
5 d 6 h
PR fusionados (30 d)
5

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Eventuous/eventuous

Todos los issues de Eventuous/eventuous

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.