2.0: `commit list main` is refused, a short Commit id to `commit diff` is reported as a Branch, `project list` has no `has_more`

Abierto
  • ¿Algo no está bien?
#611 3 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust
Área
backend

Línea de trabajo

Read core/docs/issues/533/HANDOFF.md and compare its three reported gaps with the CLI behavior at commit c421d9dba. Trace the commit list, commit diff, and project list command paths and their tests; the issue identifies no implementation files or tests. Before changing behavior, resolve the open questions about main and short commit prefixes; done means the intended behaviors are decided and covered by tests.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Three of the "Known gaps found late" in core/docs/issues/533/HANDOFF.md still reproduce at c421d9dba (macOS arm64, native machine, debug build, fresh home).

1. commit list on main is refused

$ layerfs branch list gaps/p1        → items include {"name":"main", ...}
$ layerfs commit list gaps/p1 main   → {"code":"NoSuchBranch","message":"Branch main does not exist"}

S §3.3 says "On main, a Layer id is accepted wherever a Commit is", so I expected main's Layers, newest first.

2. A short Commit id to commit diff is reported as a Branch

$ layerfs commit diff gaps/p1 <66-char id> <66-char id> --paths-only   → ok
$ layerfs commit diff gaps/p1 12e0edc1c2f9 126f10bdec46                → {"code":"NoSuchBranch","message":"Branch 12e0edc1c2f9 does not exist"}
$ layerfs commit get gaps/p1 a 126f10bdec46                             → ok (commit.get accepts prefixes of 8+ characters)

3. project list has no has_more

$ layerfs commit list gaps/p1 a --page-size 1   → {"items":[...], "has_more":true, "next_page_pos":1}
$ layerfs project list --page-size 1            → {"items":[...], "next_page_pos":1}

Questions:

  • For 2: should commit.diff accept the same 8+ character prefixes as commit.get, or refuse a short id with a Commit error instead of NoSuchBranch?
  • For 1: is listing main's Layers the intended answer, and is it wanted for 2.0?

I can send small PRs against layerfs_v2_0_0 for 2 and 3, one each with a test. I'll wait for a go-ahead in case these are already in progress.

Lenguaje dominante
Rust
Estrellas
2.1k
Forks
110
Merge medio
23 h 52 min
PR fusionados (30 d)
138

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Ephemeral-AI-Lab/layerfs

Todos los issues de Ephemeral-AI-Lab/layerfs

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.