Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

cluster: registerEntity does not reopen the storage read, so messages read before registration wait for entityMessagePollInterval

Abierto
  • ¿Algo no está bien?
#9,717 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
distributed-systems

Línea de trabajo

Start in packages/effect/src/cluster/Sharding.ts at the registerEntity logic around lines 1928-1937, then trace how storageReadLatch is opened by the poll fiber and how reads reset addresses for unregistered entity types around lines 860-864. Reproduce with persisted messages and no new client message; done means registration triggers an immediate storage reread and the pending handler runs without waiting for entityMessagePollInterval.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What happens

At boot, Sharding starts reading persisted messages as soon as it is built. An entity can only register after that, because registerEntity needs Sharding. When a read finds a message for an entity type that is not registered yet, Sharding resets the address and drops the message from that read ("reset address in the case that the entity is slow to register").

registerEntity then sets the entity manager inside withStorageReadLock, but it does not open storageReadLatch. With no new client message, nothing opens the latch until the poll fiber does, after entityMessagePollInterval (10 s by default). So every persisted message for that entity waits up to 10 s after a restart.

Where (packages/effect/src/cluster/Sharding.ts on main; same shape in the published 4.0.5)
  • the read skips an unregistered type: lines 860-864 (MutableHashSet.add(resetAddresses, address));
  • with no client message and no full batch, only the poll fiber opens the latch: lines 1071-1076;
  • registerEntity sets the manager and opens only the per-type latch: lines 1928-1937.
Reproduction
  1. A SqlMessageStorage-backed SingleRunner with a persisted entity message whose handler has not run (for example, the process was killed mid-handler).
  2. Restart. Build the runner, then register the entity in a later layer.
  3. Send no new message. The handler runs about entityMessagePollInterval after boot, not at registration.

In our app (gent), a resumed turn took 10.26 s with the default interval and 0.24 s after we call sharding.pollStorage once after registerEntity. With the interval set to one hour, the message did not run within a 10 s test window.

Suggested fix

Open storageReadLatch after entityManagers.set(...) in registerEntity (when the shard set is already acquired), so messages reset during the registration window are read again at once.

Workaround

Call Sharding.pollStorage after each registerEntity at the composition root.

Lenguaje dominante
TypeScript
Estrellas
16.7k
Forks
808
Merge medio
10 h 7 min
PR fusionados (30 d)
808

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Effect-TS/effect

Todos los issues de Effect-TS/effect

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.