Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

NodeHttpServer: requests on keep-alive connections hang during graceful shutdown

Cerrado Apto para principiantes
  • ¿Algo no está bien?
#8,728 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
78/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
node.js, typescript
Área
api, backend

Línea de trabajo

Empieza en packages/platform/node/src/NodeHttpServer.ts, alrededor del finalizador de las líneas 169-173, y reproduce el comportamiento con el script de Node HTTP keep-alive del issue. Verifica que las solicitudes en conexiones existentes se gestionen o se rechacen mientras server.close() drena las conexiones, y que el tiempo de espera de apagado y el cierre forzado de sockets sigan funcionando como se espera.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
What version of Effect is running?

4.0

What steps can reproduce the bug?

Node's server.close() drains connections instead of cutting them off. It stops accepting new TCP connections and closes idle ones. An existing connection with an in-flight HTTP request stays open, and if that connection has keep-alive enabled (eg from a reverse proxy before Node), that connection will stay open even after the response gets flushed. Node keeps emitting request event for every HTTP request on that connection.

NodeHttpServer.serve handles requests by listening to Node's request event. At shutdown, its finalizer removes the listener first and only then calls server.close(). So while the server drains, Node is still accepting requests on existing connections, but Effect is no longer listening. The next request on such a connection gets no response. It hangs until the client times out or gracefulShutdownTimeout forces the socket closed.

import { NodeHttpServer } from "@effect/platform-node"
import { Effect, Latch, Layer, ManagedRuntime } from "effect"
import { HttpServer, HttpServerResponse } from "effect/http"
import http from "node:http"
import net from "node:net"

const sleep = (ms) => new Promise((resolve) => setTimeout(resolve, ms))

// Hold the first request in the handler until shutdown starts.
const requestStarted = Latch.makeUnsafe()
const releaseResponse = Latch.makeUnsafe()
const app = Effect.gen(function* () {
  yield* requestStarted.open
  yield* releaseResponse.await
  return HttpServerResponse.text("ok")
})

const server = http.createServer()
server.keepAliveTimeout = 5000
const runtime = ManagedRuntime.make(
  HttpServer.serve(app).pipe(
    Layer.provide(NodeHttpServer.layer(() => server, {
      host: "127.0.0.1",
      port: 0,
      gracefulShutdownTimeout: "3 seconds"
    }))
  )
)
await runtime.context()

// One TCP socket for both requests.
const { port } = server.address()
const socket = net.connect(port, "127.0.0.1")
let responseData = ""
let socketClosed = false
const firstResponse = new Promise((resolve) => {
  socket.on("data", (chunk) => {
    responseData += chunk
    resolve()
  })
})
socket.on("close", () => {
  socketClosed = true
})
await new Promise((resolve) => socket.once("connect", resolve))

// Start request 1, then dispose the runtime while it is in flight.
socket.write("GET /a HTTP/1.1\r\nHost: localhost\r\n\r\n")
await Effect.runPromise(requestStarted.await)
const disposed = runtime.dispose()

// Wait for Effect's finalizer to call server.close().
while (server.listening) {
  await sleep(1)
}

// Let request 1 finish while the server drains.
releaseResponse.openUnsafe()
await firstResponse
console.log(
  "first answered:", responseData.includes("HTTP/1.1 200"),
  "| closed:", socketClosed
)

// Send request 2 on the same socket, before the drain timeout.
socket.write("GET /b HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n")
await sleep(800)
const responseCount = (responseData.match(/HTTP\/1.1 200/g) ?? []).length
console.log("second answered:", responseCount === 2)

socket.destroy()
await disposed
What is the expected behavior?

During shutdown draining, the HTTP server should either (1) handle them or (2) reject new requests (on already accepted TCP connections). Right now, those connections just hang.

What do you see instead?
first answered: true | closed: false
second answered: false

Request 2 is never answered. A reverse proxy that reuses the connection waits until its own response timeout. Node's requestTimeout doesn't cap this wait because it only limits how long the server takes to receive a request.

Additional information

Cause: the listeners are removed before draining starts:

https://github.com/Effect-TS/effect/blob/bc445262eeaaba6f7f28a154023a590e193e547d/packages/platform/node/src/NodeHttpServer.ts#L169-L173

Suggested fix: detach the listeners after draining finishes:

yield* Scope.addFinalizerExit(serveScope, () =>
  Effect.ensuring(
    preemptiveShutdown,
    Effect.sync(() => {
      server.off("request", handler)
      server.off("upgrade", upgradeHandler)
    })
  )
)

server.close() still refuses new TCP connections. The shutdown timeout and forced socket closing work as before.

Lenguaje dominante
TypeScript
Estrellas
16.7k
Forks
808
Merge medio
10 h 33 min
PR fusionados (30 d)
830

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Effect-TS/effect

Todos los issues de Effect-TS/effect

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.