Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Bug: audit.sh C-001 research-artifact check has two disjoint emitters with a filename-only false positive

Abierto
  • ¿Algo no está bien?
#61 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
bash, shell
Área
cli, tooling

Línea de trabajo

Start by reading agents/audit/active-task-scan.py’s Loop 5 and completed-task-scan.py’s Loop 4, then inspect agents/audit/audit.sh Sections 10 and 11 to understand the two C-001 emitters. Run tests/unit/active_task_scan.bats and tests/unit/c001_single_emitter.bats; done means off-convention artifacts referenced in task bodies are recognized and C-001 produces one combined count while both section names remain supported. The issue reports the fix and passing tests as already applied downstream, so check whether equivalent work is still needed here.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Context

  • Framework version: 1.6.258
  • Project: 050-email-archive (shared-tooling mode)
  • Reported: 2026-09-24T21:52:36Z

Description

agents/audit/audit.sh's C-001 (inception research artifact) rule was implemented as TWO independent code paths: SECTION 10 scanned completed/ tasks (unlabeled message 'Inception task $id has no research artifact...') and SECTION 11's OE check scanned active/started-work tasks ('C-001: Inception $id has no research artifact...'). Same conceptual rule, two message formats, two disjoint counts that don't reconcile from the audit output alone (28 completed-only + 5 active-only, no combined total).

Separately, agents/audit/active-task-scan.py's Loop 5 (feeding SECTION 11) detected an artifact ONLY by filename convention (task_id substring in a docs/reports/.md basename) — completed-task-scan.py's sibling Loop 4 (feeding SECTION 10) already had a fallback to 'task body references docs/reports/' for off-convention names, but Loop 5 didn't. Concrete false positive: a task with two real, well-named-but-off-convention artifacts (docs/reports/VALUE-REVIEW-pen-.md, referenced in the task body) was flagged as having no research artifact.

Fix (applied downstream, project-side vendored patch, Pen project T-2129): (1) added the same filename-OR-body-reference fallback to active-task-scan.py's Loop 5, mirroring completed-task-scan.py's already-correct Loop 4; (2) merged audit.sh's SECTION 10 and SECTION 11 C-001 checks into one code block under one header, computing one combined authoritative count (completed + active) instead of two disjoint per-section totals, gated on either --section research or --section oe-research so existing callers of both names keep working. 13 bats tests added (tests/unit/active_task_scan.bats + tests/unit/c001_single_emitter.bats), all passing; full suite (222 tests) has zero regressions. Live-verified against the real repo: total missing dropped from the originally-reported 33 (28 completed + 5 active) to 31 (28 completed + 3 active) — the 2 fixed were genuine false positives, not backlog.

Reported via fw upstream report from field installation

Lenguaje dominante
Shell
Estrellas
16
Forks
6
Merge medio
6 h 24 min
PR fusionados (30 d)
5

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de DimitriGeelen/agentic-engineering-framework

Todos los issues de DimitriGeelen/agentic-engineering-framework

Issues similares

Más issues de Shell/Bash

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.