Pretty difficult to use
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 20/100
Línea de trabajo
Comienza con los puntos de entrada de SyntheticsApi mencionados en el informe—list_tests, get_api_test, patch_test y update_api_test—y reproduce el comportamiento de la versión 2.19.0, incluido el error de validación. Inspecciona también el comportamiento de repr() para Monitor y su campo type. El issue debe delimitarse en errores accionables, con comportamiento esperado y pruebas separados, antes de poder considerar terminada la implementación.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Describe the bug
This API is just not great.
I needed to write a script to just find & replace one Slack channel that was our notifications on monitors to another. This was … difficult.
I'm going to summarize a number of usability issues here; filing a bug for each would be onerous.
-
SyntheticsApiincludes both apatch_test, and anupdate_api_test. I have absolutely no idea what the difference between "patch" and "update" is, and the docs don't tell me. -
AFAICT,
SyntheticsApi.patch_test(as documented here) is a lie? I have the latest version of the library, and AFAICT, that, and the associated types, just don't exist. -
If you
SyntheticsApi.list_tests, you get, essentially, a list ofSyntheticsTestDetails. (It is wrapped by a pointless wrapper object, but that's whatever.) However,update_api_testrequires aSyntheticsAPITest, so you can't pass the result to it! -
If you call
get_api_test, however, you'll get the right type: aSyntheticsAPITest! But attempting to then callupdate_api_testwith that results in a runtime error:HTTP response body: {'errors': ["Additional properties are not allowed ('modified_at', 'creator', 'monitor_id', 'created_at' were unexpected)"]}I attempted a number of things to attempt to remove those properties form the object, but none of which worked. … the entire point of a type system is that if you function declares itself to take a
Foo, then you should be able to pass it instances ofFoo. If you can't, you have foo instances that aren't reallyFoo. -
#1794, which was severe enough that I have split it out to a separate bug.
-
authn issues appear to return 403, which sent me down the wrong paths for a bit.
-
Many of the types in the library, when
repr'd, do not emit faithfulreprs. For example, if yourepra monitor, you'll get,… 'type': 'synthetics alert'}This led to me writing bugs such as,
monitor['type'] == 'synthetics alert'Which is
False(!) for the above. That's because the value for'type'there is not truly a string, it's aMonitorType. Thereprhere is just … lying.Python's has built-in support for enumerations in the form of the
enummodule, and it won't do stuff like this that will leave one pulling out one's hair mid debugging session.(Even the outer type there appears to be a
dictwhenrepr()'d … but its not.)
Environment and Versions (please complete the following information):
A clear and precise description of your setup:
- version for this project in use: 2.19.0 (latest, as of the time of writing)
Additional context
As you might be able to tell from the above, most of my frustration was around the synthetics portion. I was actually successful at updating non-synthetics monitors — except for running into errors with monitors that were actually synthetics (another Liskov substitutability violation, really), and then attempting to update those with SyntheticsApi. I eventually gave up, and just did it by hand … we don't have that many synthetics.
- Lenguaje dominante
- Python
- Estrellas
- 166
- Forks
- 55
- Merge medio
- 2 d 17 h
- PR fusionados (30 d)
- 73
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de DataDog/datadog-api-client-python
-
stale
Dificultad 1/5 1-3 horas Aptitud para principiantes 72/100
DataDog/datadog-api-client-python#3535 · 1 comentario ·
-
kind/bug stale
Dificultad 3/5 1-2 días Aptitud para principiantes 66/100
DataDog/datadog-api-client-python#3717 · 3 comentarios ·
-
kind/bug stale
Dificultad 3/5 1-2 días Aptitud para principiantes 75/100
DataDog/datadog-api-client-python#3656 · 1 comentario ·
-
kind/bug stale
Dificultad 3/5 1-2 días Aptitud para principiantes 38/100
DataDog/datadog-api-client-python#3120 · 1 comentario ·
-
stale
Dificultad 3/5 1-2 días Aptitud para principiantes 45/100
DataDog/datadog-api-client-python#2986 · 1 comentario ·
Todos los issues de DataDog/datadog-api-client-python
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
anthropics/skills#1811 · 1 comentario ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
speaches-ai/speaches#678 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
datalayer/mcp-compose#42 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
conda-forge/spacy-feedstock#177 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
UKGovernmentBEIS/inspect_evals#2523 ·