Setting `host` in `Configuration` causes credentials to be sent in the clear
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 35/100
Línea de trabajo
El informe menciona Configuration(host=...), ApiClient(configuration) y MonitorsApi.list_monitors(), pero no indica ningún archivo de código fuente ni ruta de prueba. Empieza siguiendo cómo el host configurado selecciona el esquema de la solicitud y compáralo con la ruta del host predeterminado. Se considera terminado cuando los hosts configurados explícitamente usan TLS de forma predeterminada y las credenciales nunca se envían mediante la solicitud HTTP inicial; añade una prueba de regresión para el caso reproducido.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Describe the bug
Setting host in the Configuration ctor causes credentials to be sent in the clear.
To Reproduce
Take this example:
import os
from datadog_api_client import ApiClient, Configuration
from datadog_api_client.v1.api.monitors_api import MonitorsApi
configuration = Configuration(
host=os.environ['DATADOG_HOST'],
)
configuration.api_key["apiKeyAuth"] = os.environ['DATADOG_API_KEY']
configuration.api_key["appKeyAuth"] = os.environ['DATADOG_APP_KEY']
configuration.debug = True
with ApiClient(configuration) as api_client:
monitors_api = MonitorsApi(api_client)
monitors = monitors_api.list_monitors()
print('{} monitors'.format(len(monitors)))
You can tell from the debug output that we're not doing TLS:
send: b'GET /api/v1/monitor HTTP/1.1\r\nHost: <subdomain>.datadoghq.com\r\nAccept: application/json\r\n<snip>\r\n\r\n'
reply: 'HTTP/1.1 308 Permanent Redirect\r\n'
header: Date: Fri, 08 Dec 2023 23:22:03 GMT
header: Content-Length: 0
header: Connection: keep-alive
header: location: https://<subdomain>.datadoghq.com/api/v1/monitor
header: x-content-type-options: nosniff
header: strict-transport-security: max-age=31536000; includeSubDomains; preload
send: b'GET /api/v1/monitor HTTP/1.1\r\nHost: <subdomain>.datadoghq.com\r\nAccept: application/json\r\n<snip>\r\n\r\n'
reply: 'HTTP/1.1 200 OK\r\n'
header: Date: Fri, 08 Dec 2023 23:22:03 GMT
header: Content-Type: application/json
header: Transfer-Encoding: chunked
header: Connection: keep-alive
header: etag: W/"721e351f3b20293a0d2bc1301301df83"
header: x-frame-options: SAMEORIGIN
header: content-security-policy: frame-ancestors 'self'; report-uri https://logs.browser-intake-datadoghq.com/api/v2/logs?dd-api-key=pube4f163c23bbf91c16b8f57f56af9fc58&dd-evp-origin=content-security-policy&ddsource=csp-report&ddtags=site%3Adatadoghq.com
header: vary: Accept-Encoding
header: content-encoding: gzip
header: x-ratelimit-limit: 1000
header: x-ratelimit-period: 10
header: x-ratelimit-remaining: 999
header: x-ratelimit-reset: 7
header: x-ratelimit-name: get_all_monitors
header: x-content-type-options: nosniff
header: strict-transport-security: max-age=31536000; includeSubDomains; preload
240 monitors
That double request is pretty clearly an HTTP→HTTPS redirect. Wireshark confirms as much. Oddly, whatever the default for host is doesn't do this, but I didn't realize until much later that setting host isn't required, see the Additional Context section. Initially, I was under the impression that configuration of what DD tenant I was was required.
Expected behavior
TLS is enabled by default … and ideally only switch off very explicitly. Certainly overriding things like hostname don't then also remove TLS, in addition…
Environment and Versions (please complete the following information):
A clear and precise description of your setup:
- version for this project in use: 2.19.0
- services, libraries, languages and tools list and versions: the minimal example above
Additional context
I ended up setting host almost by accident. Initially, I was getting 403 Forbidden from the API, and wasn't sure why; I was using the "Getting Started" example, and setting an API key. It turns out DD requires both an API key and an "app" key (the README does note this, but I missed that in my first pass), which is somewhat unusual. So, AFAICT, I wasn't authenticated, but since the wrong HTTP status was getting returned, that never clicked, and I tried other things (such as configuring my host) prior to returning to the what-if of "perhaps it is, indeed, authn?"
I'm not clear on why one can construct a DD client without (full) credentials without error in the first place.
- Lenguaje dominante
- Python
- Estrellas
- 166
- Forks
- 55
- Merge medio
- 2 d 17 h
- PR fusionados (30 d)
- 73
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de DataDog/datadog-api-client-python
-
stale
Dificultad 1/5 1-3 horas Aptitud para principiantes 72/100
DataDog/datadog-api-client-python#3535 · 1 comentario ·
-
kind/bug stale
Dificultad 3/5 1-2 días Aptitud para principiantes 66/100
DataDog/datadog-api-client-python#3717 · 3 comentarios ·
-
kind/bug stale
Dificultad 3/5 1-2 días Aptitud para principiantes 75/100
DataDog/datadog-api-client-python#3656 · 1 comentario ·
-
kind/bug stale
Dificultad 3/5 1-2 días Aptitud para principiantes 38/100
DataDog/datadog-api-client-python#3120 · 1 comentario ·
-
stale
Dificultad 3/5 1-2 días Aptitud para principiantes 45/100
DataDog/datadog-api-client-python#2986 · 1 comentario ·
Todos los issues de DataDog/datadog-api-client-python
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
anthropics/skills#1811 · 1 comentario ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
speaches-ai/speaches#678 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
datalayer/mcp-compose#42 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
conda-forge/spacy-feedstock#177 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
UKGovernmentBEIS/inspect_evals#2523 ·