Closed vocabularies for the tag input type still allow custom values as long as there's a suggestion present

Abierto
  • ¿Algo no está bien?
#6,332 0 comentarios 1 reacción 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@jensvannerum ya está trabajando en esto.

Desde el 6/10/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

affects: 10.x affects: 8.x affects: 9.x affects: main bug claimed: Atmire component: controlled vocabulary component: submission

Describe the bug

Even when a vocabulary is closed, if you use the tag input type for it, your input will always be appeneded to the list as a 'suggestion', allowing you to submit any value (as long as your input causes a suggestion to show).

To Reproduce

  1. Set any field up in the back end's submission-forms.xml to use a vocabulary with closed=true and input type tag e.g:
                <field>
                    <dc-schema>dc</dc-schema>
                    <dc-element>subject</dc-element>
                    <dc-qualifier></dc-qualifier>
                    <repeatable>true</repeatable>
                    <label>Subject Keywords</label>
                    <input-type>tag</input-type>
                    <hint>Enter appropriate subject keywords or phrases.</hint>
                    <required></required>
                    <vocabulary closed="true">srsc</vocabulary>
                </field>
  1. Start tying a value that appears in the vocabulary, but only partially so that your input is not in the vocabulary
  2. Verify that your input is shown as suggestion at the bottom of the list, you can click it, it's added as a tag and you can save/submit

In the images below you can see how I add "tes" which is NOT in my vocabulary

Image Image Image

Expected behavior

A clear and concise description of what you expected to happen.

I've already got a fix on DSpace 9, so I will claim this issue myself and re-do it against the latest main

Lenguaje dominante
TypeScript
Estrellas
180
Forks
577
Merge medio
2 d 1 h
PR fusionados (30 d)
100

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de DSpace/dspace-angular

Todos los issues de DSpace/dspace-angular

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.