Decide whether the catalogue cuts on ShapePipe's external_paired_fraction

Abierto
  • ¿Algo no está bien?
#444 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@cailmdaley ya está trabajando en esto.

Desde el 30/10/2026.

  • #446 de @cailmdaley — abierto

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
python
Área
data

Línea de trabajo

Read the sp_validation decision record and the catalogue selection code that consumes ShapePipe's tile_make_cat.json; the payload does not name their paths. Start with the existing decision record and the eight-tile diagnostic at /scratch/cdaley/match-guard-diag/report.html. Record whether selection cuts tiles or masks area using external_paired_fraction, and the threshold, or record that no cut is chosen.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Claude Opus on behalf of Cail.

ShapePipe (CosmoStat/shapepipe#981) no longer rejects a tile when DR6 objects fail to pair with SExtractor detections. Those losses are external-only: a DR6 object with no SExtractor detection gets no shape. The tile warns above max(20, 0.02 N + 50) and publishes its counts in tile_make_cat.json beside final_cat: the five match counts, external_paired_fraction and the warning budget, per TILE_ID, including zero-row tiles.

Nothing applies a cut on this downstream, so every object on a sparse edge tile enters the catalogue. 058.220 (71 external-only out of 845) and 207.238 both exceed the warning budget. sp_validation reads no catalogue_match field and records no decision about it.

To decide: whether the catalogue selection cuts tiles, or masks area, on external_paired_fraction, and at what threshold. Leaving them uncut is also a valid decision; if chosen, it gets recorded as one. Either way, the choice goes into sp_validation's decision record. ShapePipe's detection.tile_detection rationale says the cut is undecided and points here.

Evidence: the eight-tile diagnostic is on Nibi at /scratch/cdaley/match-guard-diag/report.html.

Lenguaje dominante
Python
Estrellas
2
Forks
5
Merge medio
22 h 26 min
PR fusionados (30 d)
30

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de CosmoStat/sp_validation

Todos los issues de CosmoStat/sp_validation

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.