ENH: Replace test hooks in simplnx production code with real failures where they are reliable
Los mantenedores suelen responder en 6 días
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
Línea de trabajo
Start by inventorying the hooks named in the issue and the tests that use them, including the persistence, bounded-read and selected-import areas. For each hook, determine whether a real failure reliably reaches the same step on Linux, Windows and macOS CI. Replace and remove hooks only when that path is reliable and simplifies both test and production code; keep hooks for the listed failure cases that real failures cannot reliably reach.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
Replace test hooks in simplnx production code with real failures where a real failure reliably reaches the same step, and remove the hooks that this replaces. This is a follow-up to the out-of-core review PR tree, mainly #1933 (checked flush), #1934 (selected import) and #1935 (bounded reads). Those PRs keep their hooks, and the review decided to do this work here, hook by hook.
How it works now
Many failure tests use fault injection that is compiled into the production libraries when SIMPLNX_BUILD_TESTS is ON. Examples:
ParallelChunkCodec.hpp:SetCodecIoObserverForTesting,InjectCodecFaultForTesting, theLegacyPayload...ForTestingscopes and theSIMPLNX_OBSERVE_*macros that wrap HDF5 calls.ImportH5ObjectPathsAction.hpp:setPublicationFaultForTestingand related functions. Most of these go away with the smaller selected-import design (separate issue).GroupIO.hpp:FailNextGroupConstructionForTesting.WindingTransferWarnings.hpp:SetWindingWarningFailureForTestingandMaybeFailWindingWarningForTesting.IdentifySampleCCL.hpp: the slice observer, extra allocation and diagnostic controls.BoundedRead.hpp:MakeSuccessWarningsForTesting.
The hooks add code, state and exported functions to shipping headers, and tests that depend on them break when the code is simplified. Once DREAM3D-NX BlueQuartzSoftware/DREAM3DNX#1247 merges, release presets build with SIMPLNX_BUILD_TESTS OFF, so the hooks will not be in shipped libraries.
Requested change
For each hook:
- Replace it with a real failure (a read-only or missing file, a removed group, a corrupted compressed chunk, a directory that cannot be created) when that failure reliably reaches the intended step on Linux, Windows and macOS CI, and when the change makes the test and the production code simpler. Then remove the hook.
- Keep it when no real failure reliably reaches the step. Examples: a failure after publication or during rollback, a second-chunk read failure, a failure during cleanup or checked close, two failures at once, and allocation failures.
- Do not weaken the failure assertions, and do not add a new abstraction only to remove hooks.
Which hooks can be replaced is still open. The first step is an inventory of each hook, the tests that use it, and whether a real failure reaches the same step.
The design reviews list this as persistence D7, bounded-reads D4 and selected-import D7. The SimplnxOoc hooks are a separate issue in that repository.
- Lenguaje dominante
- C++
- Estrellas
- 18
- Forks
- 15
- Merge medio
- 4 d 23 h
- PR fusionados (30 d)
- 42
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de BlueQuartzSoftware/simplnx
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
BlueQuartzSoftware/simplnx#1987 ·
Los mantenedores suelen responder en 6 días
-
documentation
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
BlueQuartzSoftware/simplnx#1980 ·
Los mantenedores suelen responder en 6 días
-
Testing
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
BlueQuartzSoftware/simplnx#1979 ·
Los mantenedores suelen responder en 6 días
-
documentation
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
BlueQuartzSoftware/simplnx#1978 ·
Los mantenedores suelen responder en 6 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
BlueQuartzSoftware/simplnx#1945 ·
Los mantenedores suelen responder en 6 días
Todos los issues de BlueQuartzSoftware/simplnx
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
HarperFast/rocksdb-js#1118 ·
Los mantenedores suelen responder en 1 día
-
bug triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
Los mantenedores suelen responder en 1 día
-
26.04 bug dark-mode Easy Hack impress symptom: visual
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
CollaboraOnline/online#16421 · 1 comentario ·
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 63/100
telegramdesktop/tdesktop#31653 ·
Los mantenedores suelen responder en 1 día
-
area/cs bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
ydb-platform/ydb#59881 · 1 comentario ·
Los mantenedores suelen responder en 1 día