BUG: C18: File parsing and output path checks in 22 filters

Abierto
#1,877 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 6 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
20/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
cpp

Línea de trabajo

Start with StringInterpretationUtilities.hpp, the listed reader and filter files, and WriteASCIIDataFilter.cpp as the model for output collision checks. The issue proposes one PR spanning 22 filters and shared utilities; first verify an individual checklist finding with its trigger input and add a failing test in that filter’s test suite. Done means the confirmed findings have preflight checks or safe parsing, with tests for malformed inputs and collisions; the issue says the findings have not yet been reproduced.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Summary

2026-11-13: PRs #1961, #1962, #1965, #1967, #1968, #1969, #1970, #1971 and #1972 were closed and combined into #1973, which is built and tested with the combined EbsdLib branch BlueQuartzSoftware/EbsdLib#86 (it holds EbsdLib #70 to #85, which were closed into it). Items that named one of these pull requests now also name #1973. No item is ticked until #1973 is merged.

Some filters read text files, parse numbers from strings, or derive output paths, and do not check the result. Hand-written readers index tokens without a size check and loop on eof(). String-to-number conversion accepts text that is only partly a number. Output names are made from array names or suffix rules, and preflight does not compare the final paths. Malformed input then crashes or hangs preflight, or the filter writes wrong data or overwrites a file with no error.

As of develop 419f9db35 (2026-10-21) this class has 30 open findings in 22 filters: 8 CRASH, 10 WRONG_DATA, 12 MINOR. An automated code-reading sweep found them on develop 4a7b71e5f (2026-10-08). Each finding was re-checked by reading the code on develop 419f9db35. Each finding is a candidate: nobody has run it yet.

Mechanism

This class has three sub-patterns.

1. String-to-number parsing accepts partial input. The shared converter StringInterpreterFromType calls std::stoll, std::stoull, std::stof and std::stod without the pos argument. These functions stop at the first character that is not part of a number and do not report it. StringInterpretationUtilities.hpp#L86-L94:

      else
      {
        // Default: is signed and not float
        int64 value = std::stoll(input);
        if(value > std::numeric_limits<T>::max() || value < std::numeric_limits<T>::min())
        {
          return nx::core::MakeErrorResult<T>(-10353, fmt::format("Overflow error trying to convert '{}' to type '{}' using function '{}'", input, typeName, detail::TypeToFuncName<T>()));
        }
        outputValue = static_cast<T>(value);

So "2.5" becomes 2, "1e3" becomes 1 and "12abc" becomes 12, with no error. The unsigned branch rejects a leading - only at index 0 (line 74), so " -1" wraps to UINT64_MAX. Every filter that uses this helper (or the CsvParser helpers) gets the same behavior.

2. Text header and line parsing without token-count, EOF, line-length or CR checks. Each reader has its own copy of the line and token code. For example ReadVolumeGraphicsFileFilter.cpp#L144-L146:

  while(buf[0] != '[' && !inputFile.eof())
  {
    std::vector<std::string> tokens = StringUtilities::split(buf, ' ');
    if(tokens[0] == k_FileFormat)

An empty line gives an empty tokens vector, so tokens[0] reads out of bounds. Related forms in other readers: while(!eof()) that never ends on a failed stream, gcount() == length checks that are never true after getline(buf, length), width(length) with no terminating NUL, and a trailing \r (CRLF) or UTF-8 BOM that stays in the token.

3. Output path or name collisions and nested selections are not detected. The output name is made from getTargetName() or from a suffix rule, and preflight compares the raw parameter values (or nothing). Two outputs can then resolve to one file or one DataPath, the output can be the input, the destination can be inside the source, or a selection can contain a path twice or a path and its parent. The result is a silent overwrite, an infinite recursion, or a late generic 'already exists' / 'does not exist' error.

The correct form for sub-pattern 3 already exists on develop in WriteASCIIDataFilter.cpp#L138-L149 (from #1765). Preflight compares the final output names, ignoring case, and returns a clear error:

    std::map<std::string, DataPath> outputNames;
    for(const auto& arrayPath : selectedDataArrayPaths)
    {
      // Some file systems treat names that differ only by case as the same file.
      const auto [iter, inserted] = outputNames.emplace(StringUtilities::toLower(arrayPath.getTargetName()), arrayPath);
      if(!inserted)
      {
        return MakePreflightErrorResult(k_DuplicateOutputName,
                                        fmt::format("In Multiple Files mode, DataArrays '{}' and '{}' have the same output name when case is ignored. Select DataArrays with different names.",
                                                    iter->second.toString(), arrayPath.toString()));
      }
    }

WriteBinaryDataFilter writes files with the same naming rule but does not have this check.

Rule

Decision needed: no rule for this class is decided yet. Proposed rule:

  • Numbers: A string converts to a number only if the whole string (after trimming whitespace) is consumed. Otherwise the conversion returns an error. Parsing does not depend on the user's locale. Unparsable text for a bool is an error.
  • Text readers: Every reader checks that the file opened, loops on the success of the read (not on eof()), removes a trailing \r and a leading UTF-8 BOM, and checks the token count before it reads a token. A malformed line gives an error with the line number.
  • Output paths: Preflight resolves every output to its final path or DataPath (after suffixes and prefixes; absolute and normalized; case-insensitive where the file system can be). Preflight rejects duplicate outputs, output equal to an input, a destination equal to or inside the source, and selections that contain a path twice or a path and its ancestor (or removes them with a warning; decide which).

How to fix

  1. Numbers (ConditionalSetValueFilter, CreateDataArrayAdvancedFilter, ReadTextDataArrayFilter#3, ArrayCalculatorFilter): fix StringInterpreterFromType and Convert<T> in src/simplnx/Utilities/StringInterpretationUtilities.hpp once. Trim the input with StringUtilities::trimmed (StringUtilities.hpp#L224), then parse with std::from_chars and require that it consumes the whole string. (std::from_chars is already used in ReadOnScaleTableFile.cpp; floating-point from_chars support depends on the standard library version, so confirm it on all CI compilers, or use std::stod with pos and a C-locale stream.) Keep the existing error codes -10350, -10351 and -10353 where they fit. In ArrayCalculator.cpp, require that each bracket token is only digits and that the commas are exact.
  2. Text readers: Add one shared line reader (for example in src/simplnx/Utilities/) that reads with std::getline into std::string, removes \r and a BOM, and reports the line number. Add one token accessor that checks the count and returns an error. Use them in ReadBinaryCTNorthstarFilter, ReadVolumeGraphicsFileFilter, ReadDeformKeyFileV12Filter, ReadVtkStructuredPointsFilter, ReadCSVFileFilter, ConvertHexGridToSquareGridFilter and CsvParser. In CsvParser.hpp, check the result of in >> value for every element, including the last. In ReadDeformKeyFileV12.cpp, resize to numVars, not 12.
  3. Output paths and selections: Add one shared preflight helper that takes the final output paths and returns an error for duplicates. Use the WriteASCIIDataFilter check as the model. Apply it to the file writers (WriteBinaryDataFilter, WriteNodesAndElementsFilesFilter, ComputeGBCDMetricBasedFilter, ComputeGBPDMetricBasedFilter, ConvertHexGridToSquareGridFilter) and to the DataPath outputs (ComputeArrayHistogramFilter, QuickSurfaceMeshFilter, CreateGeometryFilter, CombineStlFilesFilter). Add a destination-under-source check to CopyDataObjectFilter, and duplicate/ancestor checks to DeleteDataFilter, MoveDataFilter and CombineAttributeArraysFilter. In CreateGeometry*Action, also check the result of deepCopy for nullptr.
  4. Put each check in preflight. Only a check that needs file contents that preflight does not read can go in execute.
  5. New errors use the error-code range of that filter. Codes are more negative than -10000, and each filter uses one range of 100 codes (for example, first code -47500 means all codes -47500..-47599). Check uniqueness with git grep -nE -- "-NNNN([^0-9]|$)" (do not use \b; git grep -E ignores it) on develop and on open PR refs.
  6. Remove execute-time checks that a new preflight check makes unreachable (for example the raw-path compare in ConvertHexGridToSquareGrid.cpp). Do not keep duplicate checks.

How to test

  • Write the failing test first. Each checklist line gives the trigger input.
  • Numbers: Call the converter (or run the filter) with 2.5, 1e3, 12abc and -1 for integer types, and check that each gives an error. Check that valid values (2, -1, 1.5 for float) still convert to the correct value.
  • Text readers: Write small malformed files in the test (empty line, missing closing tag, short line, CRLF line endings, BOM, line longer than the buffer, last line with no newline). Check that preflight returns an error with a clear message and does not crash or hang. For ReadTextDataArrayFilter#1, use the file 1,2,3 with 4 tuples and check that the filter returns an error. For ReadCSVFileFilter#3, check that the created DataArray names have no \r and no BOM.
  • Output paths: Set two outputs that resolve to the same file or DataPath and check for the new preflight error. For ConvertHexGridToSquareGridFilter#3, check that the input file is not changed. For CopyDataObjectFilter#1, check that preflight returns an error and does not recurse.

Conventions

  • Make one PR for the whole class. Make one commit for each filter.
  • Start each commit message with BUG:. Add a Signed-off-by line. Do not add AI attribution.
  • Start every fix with a unit test that fails on develop. If you cannot reproduce a finding, write that in the PR and on this issue with the reason. Do not force a fix.
  • Value checks need an independent expected result (oracle). Do not use the output of the code under test as the expected result.
  • Run ctest serially. Do not use -j, because the tests depend on each other.
  • Format with clang-format 19.1.1 and the repository .clang-format.
  • Do not add sentences to the filter documentation about input requirements. The generated parameter table documents them.
  • If a fix touches a filter that has a V&V report (src/Plugins/<Plugin>/vv/<Filter>.md), update every file of the V&V package of that filter (report, deviations, provenance, test tables). V&V documents reference DREAM3D 6.5.171 only.
  • Rebase on develop. Do not merge develop into the branch.

Checklist

  • CRASH · CopyDataObjectFilter · DataGroup.cpp:64 — Copy a DataGroup /G with New Parent Destination = /G (or a group under /G). Preflight does not reject a destination inside the source; DataGroup::deepCopy inserts the copy before it reads the child keys, so the copy recurses with no end. CopyDataObjectFilter#1

  • CRASH · CreateGeometryFilter · CreateGeometry2DAction.hpp:134 — Select two input DataArrays with the same name (for example /GroupA/Data and /GroupB/Data) with Array Handling = Copy. The second deepCopy returns nullptr, which the action dereferences. Same in the 1D/3D actions and Rectilinear Grid bounds. CreateGeometryFilter#2

  • CRASH · ReadBinaryCTNorthstarFilter · ReadBinaryCTNorthstarFilter.cpp:269 — Use a .nsihdr file that cannot be opened, or that ends after <Files> with no </Files>. The stream is not checked with is_open, and while(!eof()) and ReadFileList never end on a failed stream, so preflight hangs. ReadBinaryCTNorthstarFilter#1

  • CRASH · ReadBinaryCTNorthstarFilter · ReadBinaryCTNorthstarFilter.cpp:144 — Use a header line such as <Voxels> 10 20, <Min> 0 0, or an empty line inside <Location>. tokens[0]..tokens[3] are read without a size check, so preflight reads out of bounds. A missing or zero <Voxels> value causes a division by zero. ReadBinaryCTNorthstarFilter#2

  • CRASH · ReadDeformKeyFileV12Filter · ReadDeformKeyFileV12.cpp:329 — Use a User Defined Variables header that declares more than 12 variables (for example 15). The vector is resized to 12, then the loop writes numVars entries, so preflight writes past the end of the heap buffer. ReadDeformKeyFileV12Filter#2

  • CRASH · ReadDeformKeyFileV12Filter · ReadDeformKeyFileV12.cpp:667 — Use a .key file with a short line, for example RZ 1, an ELMCON line with fewer than 5 tokens, or a blank line in a data block. tokens.at(2) throws std::out_of_range in preflight, and other tokens[..]/line[..] reads are not checked. ReadDeformKeyFileV12Filter#5

  • CRASH · ReadVolumeGraphicsFileFilter · ReadVolumeGraphicsFileFilter.cpp:146 — Use a .vgi file with an empty line inside [file1] or [geometry]. StringUtilities::split returns an empty vector, and tokens[0] reads out of bounds in preflight. ReadVolumeGraphicsFileFilter#1

  • CRASH · ReadVtkStructuredPointsFilter · ReadVtkStructuredPoints.cpp:389 — Use a file with a section keyword token of exactly 1024 characters. in.width(length) lets >> read length characters and the buffer gets no terminating NUL, so std::string(buf.data()) reads out of bounds. ReadVtkStructuredPointsFilter#6

  • WRONG_DATA · ComputeGBCDMetricBasedFilter · ComputeGBCDMetricBased.cpp:351 — Set Output Distribution File = out/gbcd.dat and Output Distribution Errors File = out/gbcd_1.dat. Preflight compares raw paths, but the _1 suffix rule makes both outputs gbcd_1.dat, so one overwrites the other. ComputeGBCDMetricBasedFilter#4

  • WRONG_DATA · ComputeGBPDMetricBasedFilter · ComputeGBPDMetricBasedFilter.cpp:142 — Set Output Distribution File = out/gbpd.dat and Output Distribution Errors File = out/gbpd_1.dat. Preflight compares the raw paths, but both names resolve to gbpd_1.dat, so two streams write one file. ComputeGBPDMetricBasedFilter#5

  • WRONG_DATA · ConditionalSetValueFilter · StringInterpretationUtilities.hpp:88 — Set Value To Replace = 2.5 (or 1e3, 12abc) on an int32 array. std::stoll reads only the prefix, so the filter replaces 2 (or 1, 12) with no error. Any unparsable text for a bool array gives true. ConditionalSetValueFilter#2

  • WRONG_DATA · ConvertHexGridToSquareGridFilter · ConvertHexGridToSquareGrid.cpp:93 — Set Output Directory to the directory of the input file and Output Prefix = "". The check compares the temporary AtomicFile path with the input path, so it never matches, and commit() overwrites the input .ang file. ConvertHexGridToSquareGridFilter#3 — PR #1967 → combined into #1973

  • WRONG_DATA · CreateDataArrayAdvancedFilter · StringInterpretationUtilities.hpp:79 — Fill an int32 array with 1.5;2abc;3 (gives 1, 2, 3 with no error), or a uint64 array with 0; -1. The leading space in -1 skips the minus-sign check, so the value becomes 18446744073709551615. CreateDataArrayAdvancedFilter#5

  • WRONG_DATA · ReadCSVFileFilter · ReadCSVFileFilter.cpp:120 — Read a CRLF CSV file on macOS/Linux, or a UTF-8 file with a BOM, with the header from a line. The header line is split without removing \r and the BOM, so the created DataArray names end in \r or start with the BOM. ReadCSVFileFilter#3

  • WRONG_DATA · ReadTextDataArrayFilter · CsvParser.hpp:293 — Read a file 1,2,3 into a DataArray with 4 tuples and 1 component. Extraction failure at EOF is not checked for the last element, so the last value repeats the previous token with no error. ReadTextDataArrayFilter#1

  • WRONG_DATA · ReadTextDataArrayFilter · StringInterpretationUtilities.hpp:89 — Read the token 1.5 or 2.5e2 into an int32 DataArray. std::stoll reads only the prefix, so the value is 1 or 2 with no error. std::stof also depends on the locale (decimal comma in de_DE). ReadTextDataArrayFilter#3

  • WRONG_DATA · WriteBinaryDataFilter · WriteBinaryDataFilter.cpp:85 — Export two DataArrays with the same name (for example Geom/Cell Data/Confidence and Geom2/Cell Data/Confidence). Preflight does not check names, and each file is named <array name><ext>, so the second file overwrites the first. WriteBinaryDataFilter#1

  • WRONG_DATA · WriteNodesAndElementsFilesFilter · WriteNodesAndElementsFilesFilter.cpp:106 — Set Output Node File Path and Output Element/Cell File Path to the same file with both writers on. Preflight does not compare the paths, and the element writer truncates the file, so the node table is lost. WriteNodesAndElementsFilesFilter#1

  • MINOR · ArrayCalculatorFilter · ArrayCalculator.cpp:1027 — Use A[1.5], A[0,], A[1 2] or A[0,,1] in Infix Expression. Bracket parsing uses std::stoull and loose comma rules, so these invalid expressions are accepted (for example A[1.5] reads component 1). ArrayCalculatorFilter#9

  • MINOR · CombineAttributeArraysFilter · CombineAttributeArraysFilter.cpp:138 — Select the same DataArray twice (from Python or JSON) with Move Data = true. The filter adds two delete actions for the same path, and the second fails with a misleading 'does not exist' error (-3245). CombineAttributeArraysFilter#2

  • MINOR · CombineStlFilesFilter · CombineStlFiles.cpp:126 — Use a directory with a.stl and a.STL on a case-sensitive file system. The temporary geometry path uses only the file stem, so the two names collide and the second read fails at execute. CombineStlFilesFilter#4

  • MINOR · ComputeArrayHistogramFilter · ComputeArrayHistogramFilter.cpp:164 — Select two input DataArrays with the same name from different groups. The output group name uses only the array name, so the second CreateDataGroupAction fails with a generic 'already exists' error. ComputeArrayHistogramFilter#9

  • MINOR · ConvertHexGridToSquareGridFilter · ConvertHexGridToSquareGrid.cpp:278 — Use an LF .ang file with a header line # or # Notes. modifyAngHeaderLine calls buf.at(i) with no size check, so it throws std::out_of_range and the filter fails with an unclear error. ConvertHexGridToSquareGridFilter#5 — PR #1967 → combined into #1973

  • MINOR · DeleteDataFilter · DeleteDataFilter.cpp:105 — Select [Image/Cell Data, Image/Cell Data/FeatureIds] or the same path twice. The filter adds one delete action per path with no de-duplication, so the second action fails with 'does not exist'. DeleteDataFilter#2

  • MINOR · MoveDataFilter · MoveDataFilter.cpp:99 — Set Data to Move = [A, A/x]. The filter adds one move action per path; after A moves, A/x does not exist, so preflight fails with -6401. The order [A/x, A] succeeds. MoveDataFilter#1

  • MINOR · QuickSurfaceMeshFilter · QuickSurfaceMeshFilter.cpp:207 — Transfer a Cell array and a Feature array with the same name (for example Phases), or an array named like Face Labels. The output path uses only the target name, so the names collide with a generic 'already exists' error. QuickSurfaceMeshFilter#8

  • MINOR · ReadTextDataArrayFilter · CsvParser.cpp:20 — Set Skip Header Lines = 1 with a header line longer than 1023 characters. ReadLine compares gcount() with length, which is never true, so the stream stays failed and the filter gives a misleading -10351 error. ReadTextDataArrayFilter#2

  • MINOR · ReadVolumeGraphicsFileFilter · ReadVolumeGraphicsFileFilter.cpp:144 — Use a .vgi file whose last line Name = data.vol has no trailing newline, or a [file1] block with no Name. The while(... && !eof()) loop drops the last line, and an empty name passes fs::exists, so execute fails with -2. ReadVolumeGraphicsFileFilter#4

  • MINOR · ReadVtkStructuredPointsFilter · ReadVtkStructuredPoints.cpp:368 — Use a file with a comment line of 1024 or more characters, or a SCALARS line of 256 or more characters. ReadLine checks gcount() == length, which is never true, so later reads fail with misleading -248/-266 errors. ReadVtkStructuredPointsFilter#4

  • MINOR · ReadVtkStructuredPointsFilter · ReadVtkStructuredPoints.cpp:1100 — Use a CRLF file with SCALARS name float (no component count) or VECTORS v float. The header line is split without removing \r, so the type token is float\r and the filter fails with -240. ReadVtkStructuredPointsFilter#5

  • WRONG_DATA · ReadVtkStructuredPointsFilter · ReadVtkStructuredPoints.cpp:763 — Header Spacing and Origin are parsed without checking their numeric domains before geometry creation. (origin: sweep)

  • ERROR · ReadVtkStructuredPointsFilter · ReadVtkStructuredPoints.cpp:854 — A negative tuple count in an unselected section becomes an unsigned skip count. (origin: sweep)

  • WRONG_DATA · ReadGrainMapper3DFilter · GrainMapper3DUtilities.cpp:174 — LabDCT header spacing is not validated before geometry creation. AbsorptionCT inferred dimensions remain separately tracked in #1874. (origin: sweep) — PR #1967 → combined into #1973

  • WRONG_DATA · ReadGrainMapper3DFilter · GrainMapper3DUtilities.cpp:206 — Nonfinite LabDCT Extent, Center or VirtualShift produces a nonfinite origin. (origin: sweep) — PR #1967 → combined into #1973

  • WRONG_DATA · ReadGrainMapper3DFilter · GrainMapper3DUtilities.cpp:267 — Nonfinite AbsorptionCT Center or VirtualShift produces a nonfinite origin. (origin: sweep) — PR #1967 → combined into #1973

  • ERROR · ReadZeissTxmFileFilter · ReadZeissTxmFile.cpp:30 — Signed ImageWidth, ImageHeight and NoOfImages are converted before header-domain validation. (origin: sweep)

  • ERROR · ReadH5EspritDataFilter · ReadH5EspritDataFilter.cpp:143 — Nonpositive header grid dimensions reach unsigned shapes. (origin: sweep) — PR #1967 → combined into #1973

  • ERROR · ReadH5EspritDataFilter · ReadH5EspritDataFilter.cpp:208 — Negative header pattern dimensions pass the zero-only guard before unsigned conversion when pattern import is active. (origin: sweep) — PR #1967 → combined into #1973

  • ERROR · ReadH5OimDataFilter · ReadH5OimDataFilter.cpp:200 — Negative header pattern dimensions pass the zero-only guard before unsigned conversion when pattern import is active. (origin: sweep) — PR #1967 → combined into #1973

  • ERROR · ReadChannel5DataFilter · ReadChannel5DataFilter.cpp:136 — Signed CPR cell counts reach shape creation without positive-domain validation. Check dependent reader arithmetic too. (origin: sweep) — PR #1967 → combined into #1973

  • ERROR · ReadH5EbsdFilter · ReadH5EbsdFilter.cpp:119 — File X/Y dimensions are converted without positive-domain checks. Selected Z-interval validation remains in #1867. (origin: sweep) — PR #1967 → combined into #1973

  • ERROR · ReadH5EbsdFilter · ReadH5EbsdFilter.cpp:252 — An active invalid sample-transformation axis from the header reaches preflight origin actions before execution rejects the transform. (origin: sweep) — PR #1967 → combined into #1973

  • WRONG_DATA · ReadVolumeGraphicsFileFilter · ReadVolumeGraphicsFileFilter.cpp:115 — Size parsing accepts a numeric prefix such as 1 from 1.5 without requiring complete token consumption. (origin: sweep)

  • WRONG_DATA · ReadDeformKeyFileV12Filter · ReadDeformKeyFileV12.cpp:228 — The shared count parser accepts numeric prefixes without complete token consumption. (origin: sweep)

  • CRASH · ReadEnsembleInfoFilter · ReadEnsembleInfoFilter.cpp:120 — Negative Number_Phases from the INI file passes the zero-only check and can leave an empty visited array before visited[0]. Origin: #1873. — PR #1967 → combined into #1973

  • ERROR · ReadH5OimDataFilter · ReadH5OimDataFilter.cpp:138 — Signed header scan dimensions reach unsigned geometry shapes without positive-domain validation. Origin: #1873, file-count part. — PR #1967 → combined into #1973

  • WRONG_DATA · ReadOnScaleTableFileFilter · ReadOnScaleTableFile.cpp:442 — File bounds are stored without validating adjacent finite increase. User fallback spacing and origin remain in #1873. Origin: #1873, file-bound part.

  • WRONG_DATA · ReadAngDataFilter · ReadAngDataFilter.cpp:119 — Header XSTEP/YSTEP reach Image Geometry spacing unchecked. A numeric overflow such as XSTEP: 1e999 parses to +infinity, the reader ignores the stream failure, and a 1×1 square grid passes the grid check. Origin: #1873 sweep. — PR #1967 → combined into #1973

  • WRONG_DATA · ReadCtfDataFilter · ReadCtfDataFilter.cpp:145 — Header XStep/YStep of -1 or NaN pass the zero-only check; multi-slice reading skips the positive-step grid check, so the geometry gets negative or NaN spacing. Origin: #1873 sweep. — PR #1967 → combined into #1973

  • WRONG_DATA · ReadChannel5DataFilter · ReadChannel5DataFilter.cpp:139 — CPR GridDistX/GridDistY of -1, NaN or infinity survive the reader and become geometry spacing; only zero is rejected, at execute. Origin: #1873 sweep. — PR #1967 → combined into #1973

  • WRONG_DATA · ReadH5EbsdFilter · ReadH5EbsdFilter.cpp:124 — Root X Resolution/Y Resolution of 0, -1, NaN or infinity are copied into the geometry spacing; valid slice-level spacing does not correct them. Origin: #1873 sweep. — PR #1967 → combined into #1973

  • WRONG_DATA · ReadH5EspritDataFilter · ReadH5EspritDataFilter.cpp:146 — Header XSTEP/YSTEP of -1, NaN or +infinity survive; only exact zero is normalized to 1, and beam-index ordering ignores spacing. Origin: #1873 sweep. — PR #1967 → combined into #1973

  • WRONG_DATA · ReadH5OimDataFilter · ReadH5OimDataFilter.cpp:141 — Header Step X/Step Y of +infinity survive a valid 1×1 square-grid read and become geometry spacing. Origin: #1873, header X/Y part of ReadH5OimDataFilter#5. — PR #1967 → combined into #1973

Related issues

  • #1765 (merged) added the duplicate output-name check to WriteASCIIDataFilter. Use it as the model for sub-pattern 3.

Out of scope

  • No finding of this class is in a filter that has a V&V report (0 findings excluded).
Lenguaje dominante
C++
Estrellas
18
Forks
15
Merge medio
4 d 23 h
PR fusionados (30 d)
42

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de BlueQuartzSoftware/simplnx

Todos los issues de BlueQuartzSoftware/simplnx

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.